Closed Bug 1670830 Opened 4 years ago Closed 3 years ago

Fix flexbox-min-height-auto-002b.html on wpt

Categories

(Core :: Layout: Flexbox, task)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

Currently, all browser implementations fails flexbox-min-height-auto-002b.html and all of them render it the same way, which means the testcase may be wrong and require an update.

https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-min-height-auto-002b.html?label=master&label=experimental&aligned&q=flexbox-min-height-auto-002b.html

Note bug 1490969 is going to remove the copy under layout/reftests/w3c-css/submitted/flexbox, and treat testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox as the master copy.

In the first subtest, the image flex item's final width is 104px. This
is because the floating flex container uses shrink-wrapping to obtain
its inline-size, and the flex item's min-content contribution to the
flex container is 104px (100px height * 1/1 aspect-ratio + 4px border).
That makes the single line flex container's final cross-size become
104px, and the item's cross size is stretched to the flex container's
cross size, which is also 104px.

This test is meant to test min-height:auto behavior, so we a constraint
to the flex container's max-width so that the flex item's cross
size (width) won't get stretched.

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/83c08ef3251b
Fix the first subtest in flexbox-min-height-auto-002b.html. r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26991 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: