Closed Bug 1670856 Opened 1 year ago Closed 1 year ago

Don't switch ICE gathering state on empty offers

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

(Keywords: perf-alert)

Attachments

(2 files, 1 obsolete file)

According to https://w3c.github.io/webrtc-pc/#rtcicegatheringstate-enum ICE Gathering 'complete' should only be reached if there is at least one ICE transport available. But Firefox sets the ICE gathering state to 'complete' even for an empty offer.

Assignee: nobody → drno
Severity: -- → S3
Priority: -- → P2
Summary: Don't switch gathering state on empty offers → Don't switch ICE gathering state on empty offers
Attachment #9181198 - Attachment is obsolete: true
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/597e66664b67
Don't switch gathering to complete state with no streams. r=bwc
https://hg.mozilla.org/integration/autoland/rev/9e4bc6105c62
Added wpt test to ensure no gathering state change. r=bwc
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26225 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot

== Change summary for alert #27320 (as of Thu, 22 Oct 2020 21:59:30 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
14% build times linux64-shippable nightly taskcluster-c5n.4xlarge 2,903.65 -> 2,507.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27320

You need to log in before you can comment on or make changes to this bug.