1670856 - Don't switch ICE gathering state on empty offers

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Nils Ohlmeier [:drno]]

According to https://w3c.github.io/webrtc-pc/#rtcicegatheringstate-enum ICE Gathering 'complete' should only be reached if there is at least one ICE transport available. But Firefox sets the ICE gathering state to 'complete' even for an empty offer.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1670856: Don't switch gathering to complete state with no streams. r=bwc

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: Bug 1670856: Added a mochitest to ensure no gathering state change. r=bwc

Depends on D93310

Comment 3

[Nils Ohlmeier [:drno]]

Attachment: Bug 1670856: Added wpt test to ensure no gathering state change. r=bwc

Depends on D93310

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/597e66664b67
Don't switch gathering to complete state with no streams. r=bwc
https://hg.mozilla.org/integration/autoland/rev/9e4bc6105c62
Added wpt test to ensure no gathering state change. r=bwc

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/597e66664b67
https://hg.mozilla.org/mozilla-central/rev/9e4bc6105c62

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26225 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #27320 (as of Thu, 22 Oct 2020 21:59:30 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
14%	build times		linux64-shippable	nightly taskcluster-c5n.4xlarge	2,903.65 -> 2,507.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27320