1670884 - [wpt-sync] Sync PR 26078 - [:is/:where] Avoid scope-contains-last-matched-element check

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26078 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26078
Details from upstream follow.

b'Anders Hartvoll Ruud <[e-mail]>' wrote:

[:is/:where] Avoid scope-contains-last-matched-element check

As far as I can tell, this check exists to ensure that complex
Shadow DOM v0 selectors don't cross any boundaries they shouldn't
(see Issue 360679).

The problem is that for e.g. ::part(foo):is(:focus), the :focus part
is detected as an illegal boundary crossing, since the TreeScope of
context.scope and context.element are different.

This function doesn't seem entirely right to me, but at this point
I want to touch Shadow DOM v0 as little as possible, since it's very
close to being removed. Hence I'm basically just disabling the check
for :is/:where.

Bug: 568705
Change-Id: I2febcd37c9772b11f91ae93df87acb7649a8de91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464263
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#816112}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e69aa3d0ff4cc91a7fca5fa3029f6908a027fe98

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

TIMEOUT: 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-shadow-parts/interaction-with-nested-pseudo-class.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9192fb731839
[wpt PR 26078] - [:is/:where] Avoid scope-contains-last-matched-element check, a=testonly
https://hg.mozilla.org/integration/autoland/rev/899fd9a8629a
[wpt PR 26078] - Update wpt metadata, a=testonly

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9192fb731839
https://hg.mozilla.org/mozilla-central/rev/899fd9a8629a