1670926 - The tab-to-search animation is inverted on RTL builds

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Attachment: TTS RTL animation.mp4

[Affected versions]:

• Fx 83.0a1

[Affected platforms]:

• Windows 10 x64
• macOS 10.13

[Steps to reproduce]:

1. Launch a RTL Firefox.
2. Bookmark https://www.google.com.
3. Open a new tab write "g".

[Expected result]:

• The animation brings the message from left to right.

[Actual result]:

• The animation brings the message from right to left.

[Regression range]:

• This is not a regression.

[Additional notes]:

• Please note the attachment.

Comment 1

[Harry Twyford]

Attachment: Bug 1670926 - Fix tab-to-search animation in RTL locales. r?dao!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2165f99d5437
Fix tab-to-search animation in RTL locales. r=dao

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 2165f99d5437 (Bug 1670926) for causing mochitest failures in test_bug1639328.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/b56bda8f309d3dcd230948789d912552d998e219

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-fis-e10s%2C16&tochange=b56bda8f309d3dcd230948789d912552d998e219&fromchange=82f128a9261ced9bccc723da4d0cbf494ec60508

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318761479&repo=autoland&lineNumber=5483

Comment 4

[Harry Twyford]

I think it's fairly unlikely this patch caused the failures in test_bug1639328.html. That test seems to deal with animation timing in Fission iframes. My patch does deal with an animation, but it only reverses the direction of a simple browser chrome animation in RTL builds. Emilio, I see you wrote the test originally – do you see a reason why my patch might have broken it?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

It seems way more likely that the failure was caused by bug 1669239, which landed right before your patch... Alexandru, did the backout really fix that intermittent failure?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Doesn't seem to per bug 1671592...

Comment 7

[Harry Twyford]

Thanks Emilio. I'm going to try re-landing this patch.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ce8d1a1915
Fix tab-to-search animation in RTL locales. r=dao

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/20ce8d1a1915

Comment 10

[Alexandru Michis [:malexandru]]

Emilio, your supposition was correct.
I backed out this bug after seeing the push with failures link with the backfills, sorry for the inconveniences and thank you for looking.

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue using Fx 83.0b2 and Fx 84.0a1(2020-10-22) on Windows 10 x64, Ubuntu 20.04 LTS and macOS 10.13.