Closed Bug 1670935 Opened 5 years ago Closed 5 years ago

browser_touchbar_searchrestrictions.js is failing on try and all the time on lower resolution osx

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1663160

People

(Reporter: jmaher, Unassigned)

Details

I found a perma fail while testing all osx test jobs at a lower resolution (1280x1024 vs 1600x1200) with browser_touchbar_searchrestrictions.js, it was timing out:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=55b5c64da2195fefd5d657e8473bf6bbadff4400&searchStr=browser-chrome

in playing around, I found I could fix this:
https://hg.mozilla.org/try/rev/3795cc3b8775745843960219cb57a3a353cba086

I don't know if this is an acceptable fix, but it seems harmless.

:harry, I see you modified this test recently, any chance you could weigh in on a solution; I am happy to try something else, or put up what I have into a formal phabricator request.

Flags: needinfo?(htwyford)

Thanks for looking into this. I agree your fix seems harmless. If it fixes the timeouts for you, I think we should give it a shot. Could you please post your patch over at bug 1663160? I know this bug is for a permafail, but I think the two bugs probably have the same underlying issue.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(htwyford)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.