1670943 - Black and White printing support for macOS

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P1)

Description

[Jonathan Watt [:jwatt]]

One of the big missing features in the new printing UI on macOS is Black and White printing. The current printing dialog has a "Black & White" checkbox, but in the new UI the "Color mode" dropdown in locked to "Color". I expect this will be a major source of annoyance for users on macOS if we push the new UI out in its current state.

Comment 1

[Jonathan Watt [:jwatt]]

Emilio, is there any chance you would be able to try to add the hacky code we discussed before on Matrix? I know you're not super enthusiastic about it, but if we're going to try to ship in v83 I think we need this. :-/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ok, I can try to. Unfortunately not until tomorrow because my dog literally ate my mac's charger this weekend lol (so one should arrive tomorrow).

This should probably wait for bug 1667053 anyways though, as this is going to just add a driver-specific thing to the print settings and such.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1670943 - Add monochrome support for OSX. r=jwatt!,jfkthame!

See comments for fun.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1670943 - Remove two dead declarations in nsPrintSettingsX. r=jfkthame

While at it..

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca5de0f3b7b9
Remove two dead declarations in nsPrintSettingsX. r=jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c6ac25bb5d5
Add monochrome support for OSX. r=jwatt,jfkthame

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ca5de0f3b7b9
https://hg.mozilla.org/mozilla-central/rev/3c6ac25bb5d5

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9181595 [details]
Bug 1670943 - Remove two dead declarations in nsPrintSettingsX. r=jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Monochrome printing won't work on OSX.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Print in monochrome from the new ui.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple, pref-gated change, has been baking in for a bit.
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9181595 [details]
Bug 1670943 - Remove two dead declarations in nsPrintSettingsX. r=jfkthame

P1, fix for an obvious bug in our new print UI on macOS, approved for 83 beta 8, thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cef159676534
https://hg.mozilla.org/releases/mozilla-beta/rev/20f1b893586a

Comment 11

[Catalin Sasca, Desktop QA [:csasca]]

The option for Black and White print is available and can be selected on Firefox 84.0b4 and 85.0a1 (2020-11-23) but it won't work as it is affected by Bug 1676191 which is affecting our available color printer, and so we are not able to verify it completely