1671032 - www.youtube.com - When using a non-light theme, it adds to the end of the URL "/?themeRefresh=1" and refreshes the page on first load

Status: NEW

(Firefox :: Theme, enhancement)

Description

[Leo_sk]

Attachment: Video comparing firefox and vivaldi behaviour on youtube.com

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

1. Set dark firefox theme
2. Go to www.youtube.com and set dark theme for the site
3. Close tab and open youtube in new tab

Actual results:

Page shows a white flash while loading which then turns dark

Expected results:

White flash should not have occured. Site should have had dark background from start. Blink based browsers do not have this problem

Comment 1

[Raluca Popovici, Desktop QA]

I was able to reproduce this issue on my machine Ubuntu 18x64 and Win 10x64 with Nightly 83.0a1(2020-10-18) (64-bit) but is reproducible on chrome too.

Comment 2

[Darkspirit]

Not a WebRender bug.

Creating ui.systemUsesDarkTheme = 1 on about:config allows to set dark theme by default (bug 1641421).
I see the same behavior with Chrome Dev on Gnome XWayland, Debian Testing:
$ google-chrome-unstable --force-dark-mode https://www.youtube.com
White for a tiny moment, then dark.

If there is something that could be improved, it would likely be done as part of bug 1641179, I assume.

Comment 3

[Leo_sk]

(In reply to Darkspirit from comment #2)

Not a WebRender bug.

Creating ui.systemUsesDarkTheme = 1 on about:config allows to set dark theme by default (bug 1641421).
I see the same behavior with Chrome Dev on Gnome XWayland, Debian Testing:
$ google-chrome-unstable --force-dark-mode https://www.youtube.com
White for a tiny moment, then dark.

If there is something that could be improved, it would likely be done as part of bug 1641179, I assume.

Its strange vivaldi behaves different to chrome. Does the same white flash happen in chrome when youtube.com is explicitly set to dark theme rather than system default?

Comment 4

[Darkspirit]

(In reply to Leo_sk from comment #3)

Does the same white flash happen in chrome when youtube.com is explicitly set to dark theme rather than system default?

Conditions:
System: (apparently) a light theme.
YouTube: manually set to dark in the top-right 3 dot menu.

Chrome Dev test:
Yes, YouTube is white for a tiny fraction of a second before turning dark. The flash does not occur when pressing F5 or Ctrl F5, but when loading additional YouTube tabs.

Comment 5

[Leo_sk]

Well, I guess it would be an enhancement then. Not much of big deal and can be solved by using dark reader, but irritating nonetheless. I still wonder what vivaldi does different

Comment 6

[Leo_sk]

I don't what changed, but it is fixed in nightly 84.0a1 (2020-10-31)

Comment 7

[08xjcec48]

Please mark this abandoned issue as a duplicate of Bug 1938521.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[08xjcec48]

Since you've decided to close the newer bug instead, please move this one to the Web Compatibility component and set the platform from Linux to All.

Firefox just tells YouTube that you have prefers-color-scheme set to dark. Firefox isn't responsible for how YouTube handles that information.

Comment 11

[Calin Tanase]

Dark theme isn't the default, as long as the issue reproduces only in this case then there's no point moving it, unless the devs have a different opinion.