Closed
Bug 1671049
Opened 4 years ago
Closed 4 years ago
Optimize AXSubrole
Categories
(Core :: Disability Access APIs, defect, P1)
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Whiteboard: [mac2020_2])
Attachments
(2 files)
The Gecko Profiler shows moxSubrole as potential hot path. I assume this is because it is called often on every kind of accessible. Since aria roles are typically constant through the life of accessibles (with the exception of role=application on body), it should easy to cache the aria role in the mozAccessible.
|
Assignee | |
Updated•4 years ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Besides the ARIA role invalidation, this fixes an issue where the mozAccessible's role is also incorrect when the aria role changes on a body tag.
Depends on D93439
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f68496da1fa8
Cache proxy ARIA role in mozAccessible. r=morgan
https://hg.mozilla.org/integration/autoland/rev/fcc450a1b8c3
Invalidate cached ARIA role and role in mozAccessible when role changes. r=morgan
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f68496da1fa8
https://hg.mozilla.org/mozilla-central/rev/fcc450a1b8c3
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•