Remove unused Caption rep
Categories
(DevTools :: Shared Components, task)
Tracking
(firefox84 fixed)
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: namandude1008, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The Caption rep doesn't seem to be used anywhere, so let's remove it
https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/devtools/client/debugger/packages/devtools-reps/src/reps/caption.js#16
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
According to the text, leaving this file is a question mark because of no reference to this file. Therefore, should this file be removed?
Reporter | ||
Comment 2•3 years ago
|
||
The file was moved to devtools/client/shared/components/reps/reps/caption.js
Reporter | ||
Comment 4•3 years ago
|
||
no, the file is still here, and the bug is available, so you can work on it if you want :)
Assignee | ||
Comment 5•3 years ago
|
||
Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .
Reporter | ||
Comment 6•3 years ago
|
||
(In reply to NAMAN JAIN from comment #5)
Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .
Hello, you can follow https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.org
And yes, this bug should only be about removing this file, which isn't used anywhere.
Assignee | ||
Comment 7•3 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)
(In reply to NAMAN JAIN from comment #5)
Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .
Hello, you can follow https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.orgAnd yes, this bug should only be about removing this file, which isn't used anywhere.
Okay thanks man . So can I try to work upon this issue ?
Reporter | ||
Comment 8•3 years ago
|
||
sure, go ahead, the bug is now yours :)
Assignee | ||
Comment 9•3 years ago
|
||
I am stuck at a point - whether to use hg or git ? as mozilla-central repo is canonical version in mercury . so will it make any differnece ?
Reporter | ||
Comment 10•3 years ago
|
||
You can use whatever you want. Mercurial is the official tool, but a lot of people are using git (there are additional steps in the setup process, see https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development)
Assignee | ||
Comment 11•3 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #10)
You can use whatever you want. Mercurial is the official tool, but a lot of people are using git (there are additional steps in the setup process, see https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development)
Yes got it .
Assignee | ||
Comment 12•3 years ago
|
||
I have found this file in this location -> mozilla-central/devtools/client/shared/components/reps/reps/caption.js . content is same . So I just have to delete this file from the source directory and create a patch and then commit ?
Assignee | ||
Comment 13•3 years ago
|
||
https://searchfox.org/mozilla-central/source/devtools/client/shared/components/reps/reps/caption.js this is the searchfox location
Reporter | ||
Comment 14•3 years ago
|
||
(In reply to NAMAN JAIN from comment #12)
I have found this file in this location -> mozilla-central/devtools/client/shared/components/reps/reps/caption.js . content is same . So I just have to delete this file from the source directory and create a patch and then commit ?
yes, that should be all what's needed :)
Assignee | ||
Comment 15•3 years ago
|
||
after deleting that file , I did " hg commit -m "Bug 1671080 - Tried removing mozilla-central/devtools/client/shared/components/reps/reps/caption.js . r?Nicolas Chevobbe <nchevobbe@mozilla.com>" " . Then i did not see any success message and " hg wip -> @ 554579:46a0e993f8bb mh+mozilla tip Bug 1672901 - Fix failure to build with 11.0 macOS SDK. r=jya~" shows this. where I am going wrong ?
Reporter | ||
Comment 16•3 years ago
|
||
can you try to do hg rm devtools/client/shared/components/reps/reps/caption.js
, and then commit (hg commit -m "Bug 1671080 - [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe.
) ?
Assignee | ||
Comment 17•3 years ago
|
||
It shows " not removing devtools/client/shared/components/reps/reps/caption.js: file is untracked"
Assignee | ||
Comment 18•3 years ago
|
||
Okay I tried adding another caption.js file and it was untracked by hg. so i used purge to delete it .
Assignee | ||
Comment 19•3 years ago
|
||
Yes , now it shows in the hg logs changeset : 554580:2a4d09f900b5
Assignee | ||
Comment 20•3 years ago
|
||
I should now just submit the patch with moz-phab right ?
Assignee | ||
Comment 21•3 years ago
|
||
Comment 22•3 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae8a567008d6 [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe
Comment 23•3 years ago
|
||
bugherder |
Assignee | ||
Comment 24•3 years ago
|
||
Thanks for the introduction on how things actually work . Looking forward towards resolving more bugs . Great !!
Assignee | ||
Comment 25•3 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)
The Caption rep doesn't seem to be used anywhere, so let's remove it
https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/devtools/client/debugger/packages/devtools-reps/src/reps/caption.js#16
when can I join the dev/tools organization on github ?
Description
•