Closed Bug 1671080 Opened 4 years ago Closed 4 years ago

Remove unused Caption rep

Categories

(DevTools :: Shared Components, task)

Product:
DevTools
Component:
Shared Components
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: nchevobbe, Assigned: namandude1008, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1671080 - [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe
47 bytes, text/x-phabricator-request
Details | Review
Mentor: nchevobbe
Keywords: good-first-bug

According to the text, leaving this file is a question mark because of no reference to this file. Therefore, should this file be removed?

The file was moved to devtools/client/shared/components/reps/reps/caption.js

i was wondering if it has been done.

no, the file is still here, and the bug is available, so you can work on it if you want :)

Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .

(In reply to NAMAN JAIN from comment #5)

Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .

Hello, you can follow https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.org

And yes, this bug should only be about removing this file, which isn't used anywhere.

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

(In reply to NAMAN JAIN from comment #5)

Hey , i'm new to mozilla open source community . What I got to understand from this bug report is that this file is a template to distinguish text/value from a label when imported and rendered inside a component , and you want it to be removed from devtools/client/shared/components/reps/reps/caption.js ? So it would be helpful and encouraging if you guide me on how to proceed with getting access to the repo and removing it . Or how to setup environment ? Do I have to clone the repo and make a PR ? Thanks .

Hello, you can follow https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.org

And yes, this bug should only be about removing this file, which isn't used anywhere.

Okay thanks man . So can I try to work upon this issue ?

sure, go ahead, the bug is now yours :)

Assignee: nobody → namandude1008
Status: NEW → ASSIGNED

I am stuck at a point - whether to use hg or git ? as mozilla-central repo is canonical version in mercury . so will it make any differnece ?

You can use whatever you want. Mercurial is the official tool, but a lot of people are using git (there are additional steps in the setup process, see https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #10)

You can use whatever you want. Mercurial is the official tool, but a lot of people are using git (there are additional steps in the setup process, see https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development)

Yes got it .

I have found this file in this location -> mozilla-central/devtools/client/shared/components/reps/reps/caption.js . content is same . So I just have to delete this file from the source directory and create a patch and then commit ?

(In reply to NAMAN JAIN from comment #12)

I have found this file in this location -> mozilla-central/devtools/client/shared/components/reps/reps/caption.js . content is same . So I just have to delete this file from the source directory and create a patch and then commit ?

yes, that should be all what's needed :)

after deleting that file , I did " hg commit -m "Bug 1671080 - Tried removing mozilla-central/devtools/client/shared/components/reps/reps/caption.js . r?Nicolas Chevobbe <nchevobbe@mozilla.com>" " . Then i did not see any success message and " hg wip -> @ 554579:46a0e993f8bb mh+mozilla tip Bug 1672901 - Fix failure to build with 11.0 macOS SDK. r=jya~" shows this. where I am going wrong ?

can you try to do hg rm devtools/client/shared/components/reps/reps/caption.js, and then commit (hg commit -m "Bug 1671080 - [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe.) ?

It shows " not removing devtools/client/shared/components/reps/reps/caption.js: file is untracked"

Okay I tried adding another caption.js file and it was untracked by hg. so i used purge to delete it .

Yes , now it shows in the hg logs changeset : 554580:2a4d09f900b5

I should now just submit the patch with moz-phab right ?

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae8a567008d6
[devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/ae8a567008d6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Thanks for the introduction on how things actually work . Looking forward towards resolving more bugs . Great !!

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)

The Caption rep doesn't seem to be used anywhere, so let's remove it
https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/devtools/client/debugger/packages/devtools-reps/src/reps/caption.js#16

when can I join the dev/tools organization on github ?

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: