1671137 - Crash in [@ java.lang.ClassCastException: at org.mozilla.gecko.util.GeckoBundle.getString(GeckoBundle.java)] Crash when loading badssl http-login page

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[berdnikov.alexandr]

Attachment: Screenshot 2020-10-14 at 14.44.37.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15

Steps to reproduce:

1. Go to https://badssl.com/
2. Find http-login option and click it.

You can observe this behavior in all GeckoView-based browsers so far. I see the same in Focus, Nightly and Fenix.

Actual results:

Application crashes.

Expected results:

Application must not crash.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1671137 - [1.1] Only retrieve the value from HTMLInputElement instances and ensure non-null strings.

Comment 3

[Eugen Sawin [:esawin]]

Kevin, I don't have sentry access, but is this really the same crash as https://github.com/mozilla-mobile/fenix/issues/14986 given the different crash stack?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Looks like I made a mistake I was looking for issues mentioning ClassCastException and did not look closely at the stack.

Comment 5

[Chenxia Liu [:liuche]]

This looks like it's been around since 81 based on some sentry logs.

Comment 6

[Eugen Sawin [:esawin]]

Attachment: Bug 1671137 - [2.0] Add Autofill crash test for the case of id='value'.

Depends on D93693

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5928e980f659
[1.1] Only retrieve the value from HTMLInputElement instances and ensure non-null strings. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/c0a3393e4a80
[2.0] Add Autofill crash test for the case of id='value'. r=geckoview-reviewers,agi

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5928e980f659
https://hg.mozilla.org/mozilla-central/rev/c0a3393e4a80

Comment 9

[Eugen Sawin [:esawin]]

Comment on attachment 9181867 [details]
Bug 1671137 - [1.1] Only retrieve the value from HTMLInputElement instances and ensure non-null strings.

Beta/Release Uplift Approval Request

• User impact if declined: Crash on page load on sites containing form elements with id='value'.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds simple guards around using undefined/null/empty elements.
• String changes made/needed: None

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9181867 [details]
Bug 1671137 - [1.1] Only retrieve the value from HTMLInputElement instances and ensure non-null strings.

Landed in 83 nightly before the merge so we don't need to uplift to beta, thanks.