Closed Bug 1671218 Opened 4 years ago Closed 4 years ago

Enable update2 prefs on Beta

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
1

Tracking

()

RESOLVED FIXED
83 Branch
Iteration:
83.2 - Oct 5 - Oct 18
Tracking Status
firefox83 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Product and UX gave Engineering the go-ahead to enable all update2.* branch prefs on Beta.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Summary: Enable update2 prefs on Beta → Enable update2 prefs on early Beta

Why just early beta?

Flags: needinfo?(htwyford)

Isn't that the way we normally roll features out? We enable on early Beta so we don't break Release QA if the feature doesn't end up shipping. We meet again at the end of the early Beta period to decide if we the feature should ride to Release. See bug 1613869. That said, if you'd prefer I enable this for all of Beta, I can certainly do that instead.

Flags: needinfo?(htwyford)

I think the choice is just between early beta and then land a further patch for release if beta goes well, or enable for release and then land a disabling patch if beta goes wrong.

Indeed, so I think all of beta would be fine here, since we have our go-no-go for release during late-beta as well.

In that case, I'll go with Marco's approach of enabling for all of Release and then disabling later if need be. Afaict there's no combination of release flags that covers Nightly, late Beta, and Dev Edition. From https://wiki.mozilla.org/Platform/Channel-specific_build_defines#Usage:

(Also note there is intentionally no single variable covering Beta, as late Beta becomes/is Release.)

I won't dupe this to bug 1665048 since that tracks other touch-up items we should do once we get Release approval.

Summary: Enable update2 prefs on early Beta → Enable update2 prefs on Beta
Attachment #9181656 - Attachment description: Bug 1671218 - Enable update2 prefs on early Beta. r?adw! → Bug 1671218 - Enable update2 prefs on Release. r?adw,mak
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e41ebb110cf
Enable update2 prefs on Release. r=adw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: