1671221 - `static-analysis check` is broken, incorrectly passing backslashes to clang-tidy

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

mach static-analysis check lib/editor currently does nothing because _generate_path_list generates path with backslash:

['editor/spellchecker\\EditorSpellCheck.cpp', 'editor/spellchecker\\EditorSpellCheck.h', 'editor/spellchecker\\FilteredContentIterator.cpp', 'editor/spellchecker\\FilteredContentIterator.h', 'editor/spellchecker\\TextServicesDocument.cpp', 'editor/spellchecker\\TextServicesDocument.h', 'editor/spellchecker\\nsComposeTxtSrvFilter.cpp', 'editor/spellchecker\\nsComposeTxtSrvFilter.h']

This path is somehow not recognized by clang-tidy and is just ignored.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

(BTW it's currently too verbose by default, hard to catch the actual warnings.)

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1671221 - Use posix path for static analysis r=andi

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19003b5ea0de
Use posix path for static analysis r=andi

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19003b5ea0de