Closed Bug 1671221 Opened 4 years ago Closed 3 years ago

`static-analysis check` is broken, incorrectly passing backslashes to clang-tidy

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P2)

x86_64
Windows 10

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(1 file)

mach static-analysis check lib/editor currently does nothing because _generate_path_list generates path with backslash:

['editor/spellchecker\\EditorSpellCheck.cpp', 'editor/spellchecker\\EditorSpellCheck.h', 'editor/spellchecker\\FilteredContentIterator.cpp', 'editor/spellchecker\\FilteredContentIterator.h', 'editor/spellchecker\\TextServicesDocument.cpp', 'editor/spellchecker\\TextServicesDocument.h', 'editor/spellchecker\\nsComposeTxtSrvFilter.cpp', 'editor/spellchecker\\nsComposeTxtSrvFilter.h']

This path is somehow not recognized by clang-tidy and is just ignored.

(BTW it's currently too verbose by default, hard to catch the actual warnings.)

See Also: → 1671248
Priority: -- → P2
Assignee: nobody → krosylight
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19003b5ea0de
Use posix path for static analysis r=andi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: