Open Bug 1671238 Opened 4 years ago Updated 2 years ago

`static-analysis check` says 0 warnings present even when there is a warning

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement, P5)

enhancement

Tracking

(Not tracked)

People

(Reporter: saschanaz, Unassigned)

Details

 1:26.42 C:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32\_virtualenvs\init_py3\Scripts\python.exe C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/share/clang/run-clang-tidy.py -j 0 -p C:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32/static-analysis -clang-tidy-binary C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy.exe -clang-apply-replacements-binary C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/bin/clang-apply-replacements.exe -checks=-*, mozilla-can-run-script -extra-arg=-std=c++17 -extra-arg=-DMOZ_CLANG_PLUGIN -header-filter=editor/spellchecker/TextServicesDocument\.cpp -config=CheckOptions:
- key: performance-move-const-arg.CheckTriviallyCopyableMove
  value: 0
 editor/spellchecker/TextServicesDocument\.cpp
 1:26.42 C:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32\_virtualenvs\init_py3\Scripts\python.exe C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/share/clang/run-clang-tidy.py -j 0 -p C:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32/static-analysis -clang-tidy-binary C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy.exe -clang-apply-replacements-binary C:/Users/Kagami/.mozbuild/clang-tools/clang-tidy/bin/clang-apply-replacements.exe -checks=-*, mozilla-can-run-script -extra-arg=-std=c++17 -extra-arg=-DMOZ_CLANG_PLUGIN -header-filter=editor/spellchecker/TextServicesDocument\.cpp -config=CheckOptions:
- key: performance-move-const-arg.CheckTriviallyCopyableMove
  value: 0
 editor/spellchecker/TextServicesDocument\.cpp
 1:26.68 Enabled checks:
 1:26.68     mozilla-can-run-script
 1:26.68
 1:33.90 - key: performance-move-const-arg.CheckTriviallyCopyableMove
 1:33.91   value: 0
 1:33.91  C:/Users/Kagami/Documents/GitHub/gecko-dev/editor/spellchecker/TextServicesDocument.cpp
 1:33.91 C:/Users/Kagami/Documents/GitHub/gecko-dev/editor/spellchecker/TextServicesDocument.cpp:1191:48: warning: arguments must all be strong refs or caller's parameters when calling a function marked as MOZ_CAN_RUN_SCRIPT (including the implicit object argument).  'itEntry->mNode' is neither. [mozilla-can-run-script]
 1:33.91     rv = selection->CollapseInLimiter(itEntry->mNode,
 1:33.91                                                ^
 1:33.91 2 warnings generated.
 1:33.91
 1:33.91 Suppressed 1 warnings (1 with check filters).
 1:33.91
 1:33.94 0 warnings present.
 1:33.94 0 warnings present.

You can see that there are two 0 warnings presents in the message, that's because the writing to stdout is not synchronous since analysis is performed on many threads.

Priority: -- → P3
Product: Firefox Build System → Developer Infrastructure
Severity: -- → S4
Type: defect → enhancement
Priority: P3 → P5
You need to log in before you can comment on or make changes to this bug.