Closed Bug 1671320 Opened 4 years ago Closed 4 years ago

Rename test_bug1151663.html to test_group_<something>.html

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: botond, Assigned: aemad, Mentored)

References

Details

(Whiteboard: [apz-outreachy][lang=c++])

Attachments

(2 files)

In bug 1444611, we refactored test_bug1151663.html to use runSubtestsSeriallyInFreshWindows(), with the single subtest helper_bug1151663.html.

For consistency with other APZ tests that use this function, we should rename this test to start with test_group_. This way, if in the future we write related tests, we can add them as subtests in the same test group.

My suggests for what to name the group would be test_group_scrollframe_activation.html, as that's what helper_bug1151663.html is testing (that the right scroll frame gets activated on page load).

Alaa, if you'd like to work on this as a follow-up to bug 1444611, you're welcome to, it should be pretty straightforward.

Mentor: botond, kats
Whiteboard: [apz-outreachy][lang=c++]

(In reply to Botond Ballo [:botond] from comment #1)

Alaa, if you'd like to work on this as a follow-up to bug 1444611, you're welcome to, it should be pretty straightforward.

yes, i want to work on this please

Assignee: nobody → eng.alaaemad.ae
Status: NEW → ASSIGNED
Attachment #9182232 - Attachment description: Bug 1671320 - Rename test_bug1151663.html to test_group_<something>.html → Bug 1671320 - Rename test_bug1151663.html to test_group_scrollframe_activation.html
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5a5723aaa27 Rename test_bug1151663.html to test_group_scrollframe_activation.html r=botond
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: