Closed Bug 1671419 Opened 4 years ago Closed 4 years ago

Avoid unecessary computing when updating watch resources

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Type:
defect

Tracking

(Fission Milestone:MVP, firefox83 fixed)

Status:
RESOLVED FIXED
Milestone:
83 Branch
Project Flags:
Fission Milestone MVP
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

Bug 1671419 - [devtools] Avoid updating resource types if the list is empty.
47 bytes, text/x-phabricator-request
Details | Review

The watcher actor is currently emitting messages over IPC with empty resource type lists.
https://searchfox.org/mozilla-central/source/devtools/server/actors/watcher.js#274-277

This is probably harmless, but we could probably save a few cycle by doing nothing if the target specific list is empty.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

Tracking dt-fission-m2-reserve bugs for Fission MVP.

Fission Milestone: --- → MVP
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/247c0c79dc07
[devtools] Avoid updating resource types if the list is empty. r=nchevobbe
Whiteboard: dt-fission-m2-reserve → dt-fission-m2-mvp

https://hg.mozilla.org/mozilla-central/rev/247c0c79dc07

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: