1671502 - Intermittent [TV] browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | The tab-to-search result is an onboarding result. - "undefined" == "onboardTabToSearch" - JS frame :: chrome://mochitests/content/browser/browser/modules/test/bro

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=318762240&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HD_kWE5eSCOTYPpK0b6Cig/runs/1/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HD_kWE5eSCOTYPpK0b6Cig/runs/1/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2020-10-15T19:13:14.302Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | The tab-to-search result is for the correct engine. - "MozSearch" == "MozSearch" - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - Buffered messages finished
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | The tab-to-search result is an onboarding result. - "undefined" == "onboardTabToSearch" - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js :: test_tabtosearch_onboard :: line 517
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - Stack trace:
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:test_tabtosearch_onboard:517
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Urlbar should never be in search mode without the corresponding attribute. - false == false - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | gURLBar.searchMode not expected - true == true - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected placeholder l10n when search mode is inactive - {"args":null,"id":"urlbar-placeholder"} deepEqual {"id":"urlbar-placeholder","args":null} - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Sanity check: The second result is selected. - 1 == 1 - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Urlbar should never be in search mode without the corresponding attribute. - true == true - 
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-15T19:13:14.303Z] 19:13:14     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected searchMode - {"engineName":"MozSearch","isPreview":false,"entry":"tabtosearch"} deepEqual {"engineName":"MozSearch","entry":"tabtosearch_onboard","isPreview":false} - JS frame :: resource://testing-common/UrlbarTestUtils.jsm :: assertSearchMode :: line 431
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - Stack trace:
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - resource://testing-common/UrlbarTestUtils.jsm:assertSearchMode:431
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:test_tabtosearch_onboard:534
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected textContent - "MozSearch" == "MozSearch" - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected l10n - {"args":null,"id":null} deepEqual {"id":null,"args":null} - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected textContent - "MozSearch" == "MozSearch" - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected l10n - {"args":null,"id":null} deepEqual {"id":null,"args":null} - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Expected placeholder l10n when search mode is active - {"args":{"name":"MozSearch"},"id":"urlbar-placeholder-search-mode-other-engine"} deepEqual {"id":"urlbar-placeholder-search-mode-other-engine","args":{"name":"MozSearch"}} - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Search mode result matches engine host. - true == true - 
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | urlbar.searchmode.tabtosearch_onboard must be recorded. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertKeyedScalar :: line 42
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - Stack trace:
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertKeyedScalar:42
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:assertSearchModeScalar:44
[task 2020-10-15T19:13:14.304Z] 19:13:14     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:test_tabtosearch_onboard:539
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | Uncaught exception - at resource://testing-common/TelemetryTestUtils.jsm:44 - TypeError: right-hand side of 'in' should be an object, got undefined
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - Stack trace:
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - assertKeyedScalar@resource://testing-common/TelemetryTestUtils.jsm:44:1
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - assertSearchModeScalar@chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:44:22
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - test_tabtosearch_onboard@chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js:539:25
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - Leaving test bound test_tabtosearch_onboard
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - GECKO(5249) | MEMORY STAT | vsize 2837MB | residentFast 329MB | heapAllocated 118MB
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - TEST-OK | browser/modules/test/browser/browser_UsageTelemetry_urlbar_searchmode.js | took 6133ms
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - checking window state
[task 2020-10-15T19:13:14.305Z] 19:13:14     INFO - GECKO(5249) | Completed ShutdownLeaks collections in process 5249```

Comment 1

[Intermittent Failures Robot]

8 failures in 3694 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8

Platform breakdown:

• windows10-64: 2
• macosx1014-64: 2
• linux1804-64: 2
• windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1671502&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 2

[Harry Twyford]

Attachment: Bug 1671502 - Ensure tipShownCount.tabToSearch does not exceed tabToSearch.onboard.maxShown in browser_UsageTelemetry_urlbar_searchmode.js. r?adw!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/670004b11778
Ensure tipShownCount.tabToSearch does not exceed tabToSearch.onboard.maxShown in browser_UsageTelemetry_urlbar_searchmode.js. r=adw

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 670004b11778 (Bug 1671502) for causing failures in browser_UsageTelemetry_urlbar_tabtosearch.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Ho0KkF_TQBqA8Kfgw8HYmA.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=670004b117780205167aa48ef1df82e67eccd451

Failure log: https://treeherder.mozilla.org/logviewer?job_id=320259916&repo=autoland&lineNumber=2858

Backout: https://hg.mozilla.org/integration/autoland/rev/de8c9454059ed217103ad77eefeb7cba541cbff0

Comment 5

[Intermittent Failures Robot]

8 failures in 4275 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8

Platform breakdown:

• linux1804-64: 2
• windows7-32: 2
• macosx1014-64: 2
• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1671502&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 6

[Harry Twyford]

I fixed the patch and I'm waiting for try: https://treeherder.mozilla.org/jobs?repo=try&revision=b8490babbade86939f83d90c92ad737f4c715008

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff800d08ea37
Ensure tipShownCount.tabToSearch does not exceed tabToSearch.onboard.maxShown in browser_UsageTelemetry_urlbar_searchmode.js. r=adw

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ff800d08ea37