1671536 - Remove Base Profiler PayloadMarker and all dependencies

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Base Profiler PayloadMarker-based markers are not used much, so they can be removed without too much effort.

Bug 1670954 (MarkerThreadId::MainThread) is needed to convert a couple of TextMarkerPayload uses to the new API.

(The same task will happen in the Gecko Profiler, but there is more work needed to convert the old PayloadMarkers to markers 2.0 first, so there will be separate bugs for that, see meta bug 1661394.)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1671536 - Stop using baseprofiler::TextMarkerPayload - r?gregtatum

TextMarkerPayload is the only legacy marker type that is still used in the Base Profiler. We're converting it to the new BASE_PROFILER_MARKER_TEXT.

Depends on D93736

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1671536 - Remove BaseProfilerMarkerPayload.h and dependents - r?gregtatum

Everything related to Base Profiler legacy markers can now be removed, only the new API from BaseProfilerMarkers.h should now be used.

Depends on D93737

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24bc2812bca9
Stop using baseprofiler::TextMarkerPayload - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/c14038de028d
Remove BaseProfilerMarkerPayload.h and dependents - r=gregtatum

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/24bc2812bca9
https://hg.mozilla.org/mozilla-central/rev/c14038de028d