1671569 - Allow clang version tests on macOS with Xcode

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

I found a way-ish to get rid of https://treeherder.mozilla.org/#/jobs?repo=try&revision=7118a7ae479ffd00cdd4dfe522b7dbab218fb5dc

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Is that link supposed to be to https://treeherder.mozilla.org/#/jobs?repo=try&revision=9472c642f9ad6631da63eb9c86ba903815d77eb3&selectedTaskRun=Gm1cwomqSXGeQsA1eij6GQ.0?

Comment 2

[Mike Hommey [:glandium]]

Dammit Firefox! The link was supposed to be https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/build/moz.configure/toolchain.configure#391-398,405

Comment 3

[Ricky Stewart]

How exactly does this block bug 1671376? Are you planning to conditionally disable -Wmissing-braces for those versions of Clang > 6.0?

Comment 4

[Mike Hommey [:glandium]]

yes.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1671569 - Normalize Xcode clang version to the underlying plain clang version.

We used to have a complicated scheme to figure out the minimum supported
version of clang on OSX, based on some compiler feature, which wouldn't
allow to do other version checks further down the line.

The main blocker for better tests was to be able to distinguish between
Xcode clang and plain clang, which turns out to be possible with the
apple_build_version define.

We still need to map versions manually, but it's better than the current
status quo.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d45d366667c
Normalize Xcode clang version to the underlying plain clang version. r=firefox-build-system-reviewers,rstewart

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4d45d366667c