1671583 - Perma wasm/jsapi/global/type.tentative.any.js | can't access property "value", myglobal.type is undefined [0.1 s] when Gecko 83 merges to Beta on 2020-10-19

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1651725 (?) caused a second test to fail.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=0571d2a6280b405e499015bdbeb4ecd1ad12d696&selectedTaskRun=IdMLv1-eT6-SM32LeB0LCg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=318817565&repo=try

TEST-UNEXPECTED-FAIL | wasm/jsapi/global/type.tentative.any.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so --baseline-eager") | can't access property "value", myglobal.type is undefined [0.1 s]

Comment 1

[Jessica (ooo; ni? to wingo)]

I'm looking at this now.

Comment 2

[Jessica (ooo; ni? to wingo)]

Attachment: Bug 1671583 - Add missing expectation for failing wpt wasm test

Comment 3

[Jessica (ooo; ni? to wingo)]

Attachment: Bug 1671583 - Add missing expectation for failing wpt wasm test

Comment 4

[Lars T Hansen [:lth]]

Jessica, did you mean to ask for review on those patches?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5978bef9d985
Add missing expectation for failing wpt wasm test r=lth

Comment 6

[Jessica (ooo; ni? to wingo)]

This should have fixed the bug.

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5978bef9d985

Comment 8

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Cretry%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=02ea192878dc180162a7ffcef3c1bd2d18642a59&searchStr=sm

Comment 9

[Razvan Maries]

This error has occurred on today's Beta as Release simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=90c6b1f36ac3e9d8ff68b6aaa591c6611d9ac011&searchStr=sm&selectedTaskRun=QTvixdK3TBeohsHZvFv6Lg.0

I think this patch should be uplifted on beta.

:jtallon, could you take a look?

Comment 10

[Lars T Hansen [:lth]]

Yeah, uplift required.

Comment 11

[Lars T Hansen [:lth]]

Comment on attachment 9182426 [details]
Bug 1671583 - Add missing expectation for failing wpt wasm test

Beta/Release Uplift Approval Request

• User impact if declined: None, but wpts will continue to fail
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a 'test should fail' expectation (only)
• String changes made/needed:

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9182426 [details]
Bug 1671583 - Add missing expectation for failing wpt wasm test

Approved for 83 beta 3, thanks.

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0259155792cf