1671610 - [wpt-sync] Sync PR 26136 - [grid] Relayout grid items when definiteness changes.

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26136 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26136
Details from upstream follow.

b'Ian Kilpatrick <[e-mail]>' wrote:

[grid] Relayout grid items when definiteness changes.

Previously LayoutGrid performed a simple logical-height change check
to determine if a grid-item needed relayout.

This wasn't correct as when setting an override logical-height the
definiteness can change causing %-height children to resolve
differently.

This became troublesome after we moved relative-positioning into NG
as %-block-start, %-block-end offsets weren't resolving correctly.

This however also fixes other issues such as test:
percentage-size-subitems-002.html

Where LayoutGrid wasn't performing a relayout causing grandchild to size
incorrectly.

This may have a performance hit for any legacy children being having
layout performed by a LayoutGrid, however should be fine for an NG child
as we have much more precise cache logic for this case.

The following tests have been marked as failing:
virtual/layout-ng-grid/external/wpt/css/css-grid/relative-grandchild.html
virtual/layout-ng-grid/external/wpt/css/css-grid/grid-items/percentage-size-subitems-002.html
as GridNG doesn't correctly set up the constraint spaces yet.

Bug: 1138504, 1018439
Change-Id: Iac2484f1b175f152e491f421449fb7b555c9e125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474917
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#817631}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=025f139b97c1a2161aa13e1387c50045d5b2f297

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c522d7b82d
[wpt PR 26136] - [grid] Relayout grid items when definiteness changes., a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/17c522d7b82d