1671906 - Share notifyResourceAvailable, notifyResourceUpdates and notifyResourceDeleted between watcher and target actors

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

These methods have the same implementation (or should have) and should be written once.
The issue is that Actors aren't use ES Classes (only Fronts do), and so it is harder to share code via inheritance.

We could probably also share: addWatcherDataEntry, removeWatcherDataEntry, watchTargetResources and unwatchTargetResources between all target actors.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1671906 - [devtools] Introduce a target actor mixin in order to share common code between all targets.

Similarly to the frontend, I'm introducing a mixin in order to share code between at target actors.
We might be able to share more, like sources. But at least we share new addition related to watcher and resources.
This would probably have been easier if Actor were using ES Classes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5834209a1e4f
[devtools] Introduce a target actor mixin in order to share common code between all targets. r=jdescottes

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5834209a1e4f