1671937 - Create Fly-Out customize component

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Erica Wright [:ewright]]

Attachment: Screen Shot 2020-10-19 at 10.22.44 AM.png

The New Tab page will allow users to customize the page without leaving the page. Initially we will do this with a component which will expand and overlay a side of the page. THere will be a gear in the upper corner labeled "Customize" which, when clicked, will trigger this component to expand.

This component should have sections: "Theme", "Home Background", "Home Content".

This component should obey the parent pref to turn on/off and should have it's own pref for future testing.

See image attached for UX guidance.

Comment 1

[:prathiksha]

Attachment: Bug 1671937 - Create a fly-out customization menu component for the newtab page.

Depends on D95043

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9178fe846d75
Create a fly-out customization menu component for the newtab page. r=ewright,thecount

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1671935, Bug 1671937) for causing node newtab failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3cf3e2c42a0d8bff0b928f78b11662d38dfa1df4

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=ce6c4c4c67008a1998aba2be3d4a3cc683793b31&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnewtab&tochange=9178fe846d7596e09844954c44198aa4550b9df3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322061115&repo=autoland&lineNumber=90

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ad8ebb7f78b
Create a fly-out customization menu component for the newtab page. r=ewright,thecount

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0ad8ebb7f78bfc79da67d6dff80739bbe7dd2e1f

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "customization menu component" is opened if the "browser.newtabpage.activity-stream.customizationMenu.enabled" pref is set to true in the "about:config" page and the "Customize you New Tab page" button from the top-right part of the page is clicked. However, I've observed that no other elements are displayed in the "customization menu component" besides the "Done" button.

@Prathiksha, in order to mark this enhancement as "Verified", should we check only that the customization menu component is correctly opened, or should we also verify that all the elements from it are correctly displayed according to the image from the bug's description?

Comment 7

[Erica Wright [:ewright]]

@mcoman Thanks for verifying! This bug is only for the base component to exist so that the two of us can then start filling it in with relevant pieces from the designs. The designs have since changed and the rest of this customize menu is still being actively developed.

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

Hi Erica and thanks for the quick answer! Based on your answer and the verification performed in comment 6, I am marking this enhancement as Verified.

Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201123214551) installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15.