1671960 - Add fast-path of AtomizeChars in ParserAtomEntry::toJSAtom

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

ParserAtoms has the same static strings as JSAtoms,
and ParserAtomEntry::toJSAtom handles them separately before AtomizeChars.
we don't have to lookup static string on JSAtom side.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1671960 - Skip static string lookup in when instantiating ParserAtom. r?tcampbell!

Depends on D94097

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1671960 - Forward HashNumber from ParserAtom to JSAtom. r?arai!

Since we use the same HashString for both types of atoms, we can save some
time while converting between them by reusing the HashNumber. This is
beneficial for Stencil-XDR where decoding times are quite fast and handling
atoms is a noticeable delay.

Comment 3

[Ted Campbell [:tcampbell]]

We discovered that the since JSAtom uses static-strings for more cases than ParserAtoms, we still need the static strings code. I am repurposing this bug to instead pass the HashNumber to the special AtomizeChars call.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaedffcfb8a1
Forward HashNumber from ParserAtom to JSAtom. r=arai

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/aaedffcfb8a1