1672006 - Add Herald rule for #ipc-reviewers group

Status: RESOLVED FIXED

(Conduit :: Administration, task)

Description

[Nika Layzell [:nika] (ni? for response)]

In bug 1671944, the ipc-reviewers group was added, but I didn't realize I couldn't add the herald rule for it myself.

It would be nice to have a herald rule which marks the #ipc-reviewers group as a blocking reviewer for a revision if it modifies the sync-messages.ini file, such that phabricator can help catch issues which would trigger the prevent_sync_ipc_changes.py mercurial hook from rejecting the patch and add us as reviewers early.

Ideally the check would look something like: If the revision changes a file named sync-messages.ini, and the revision's author is not a member of the ipc-reviewers group, then add the ipc-reviewers group as a blocking reviewer. (It's also OK if we can't add the exception for authors who are in the ipc-reviewers group - I'm not certain whether that sort of condition is possible with herald)

Comment 1

[David Lawrence [:dkl]]

Done

https://phabricator.services.mozilla.com/H279

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I have an r+ from jld / ipc-reviewers:
https://phabricator.services.mozilla.com/D93343

But it refuses to land:
https://lando.services.mozilla.com/D93343

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I had the option to approve the change as myself and/or as ipc-reviewers, and chose the latter only. But the commit hook doesn't know what r=ipc-reviewers means; that should be relatively simple to fix.