Closed Bug 1672023 Opened 8 months ago Closed 8 months ago

Remove excluded files from black.yml

Categories

(Firefox Build System :: Lint and Formatting, task)

task

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

Details

Attachments

(1 file)

These files were excluded from auto-formatting since black introduces errors that conflict with other lints; they should be manually removed from this list after noqa'ing the relevant lines.

Looks like the flake8 and black linters disagree about what the maximum line length should be (black will reformat lines to be 100 characters long, but flake8 wants every line to be at most 99 characters). This introduces issues in files like taskcluster/taskgraph/transforms/bouncer_aliases.py. Not sure if there's a configuration that needs to be updated somewhere?

Flags: needinfo?(sledru)

what about updating the flake8 config to be 100?
It is defined here: https://searchfox.org/mozilla-central/source/.flake8#2

Flags: needinfo?(sledru)

These files were omitted from the original patch because reformatting them required some manual intervention in order to avoid breaking unit tests. Generally the noqa lines were already there and just needed to be moved from one line to another (due to the reformatting by black), but sometimes black saw fit to move a bunch of stuff all onto one line, requiring me to introduce new noqa lines.

Besides the autoformat by black and some manual fixups, this patch contains no other changes.

Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94ec15429e21
Remove excluded files from `black.yml` r=sylvestre,perftest-reviewers,geckoview-reviewers,agi
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c9ab7d45852
Backed out changeset 94ec15429e21 for Backout conflicts with Bug 1654103. CLOSED TREE
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff3fb0b4a512
Remove excluded files from `black.yml` r=sylvestre,perftest-reviewers,geckoview-reviewers,agi
Flags: needinfo?(rstewart)
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e46822faf5d8
Remove excluded files from `black.yml`
Flags: needinfo?(rstewart)
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.