1672087 - Handle RDD crashes smoothly

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

The GPU RemoteDecoder will handle the case where the GPU process crashed elegantly. The GPU process will be restarted, and if needed HW decoding will be disabled if it continues crashing.

Video playback will temporary pause and resume, the error being completely transparent to the video element.

The RDD process on the other hand, when crashing will just cause a decoding error and stop. It will be restarted the next time we need a new decoder.

This behaviour was sufficient when the RDD only managed software decoding, and would pretty much never crash.

Now that the RDD can do HW decoding and use GPU image surface, it has the same chances of crashing as the GPU process.

We need to have RDD crashes handled like the GPU crashes.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1672087 - P1. Remove unused value. r?mattwoodrow

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1672087 - P2. Recreate remote decoder when parent dies. r=mattwoodrow!,bryce!,padenot!,mjf!

The RDD process startup being asynchronous make the operation trivial. Unlike with the GPU process, we can immediately tell the MediaFormatDecoder that a new decoder is needed when the RDD died.

Recovery will immediately occur with little visible interruption.

Depends on D98570

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/603841cbec35
P1. Remove unused value. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/cb44922f2e7a
P2. Recreate remote decoder when parent dies. r=mattwoodrow,bryce

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/603841cbec35
https://hg.mozilla.org/mozilla-central/rev/cb44922f2e7a