1672132 - remove isFirefoxPanel check in boostrapApp

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

The check was done for supporting launchpad, we shouldn't have it now.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1672132 - [devtools] Inline renderPanel into boostrapApp. r=jdescottes.

boostrapApp had a check for supporting the Launchpad, that we can now remove.
And since renderPanel is only called from there, we can safely inline it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cdea80e8600
[devtools] Inline renderPanel into boostrapApp. r=jdescottes.

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 5cdea80e8600 (Bug 1672132) for causing debugger failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=TA9O9YqjQSKVuhuD31WGzw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=5cdea80e86009e9b583d086364ac01166459becd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319136857&repo=autoland&lineNumber=562

Backout: https://hg.mozilla.org/integration/autoland/rev/bd8c26f71682e2b0a3e79e91b824c30f17aa9043

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

the patch was updated which fixed the flow error

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7abfe9ea6def
[devtools] Inline renderPanel into boostrapApp. r=jdescottes.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7abfe9ea6def