1672146 - UrlbarProviderSearchTips should deal with update manager not existing

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[:Gijs (he/him)]

On distro builds on Linux, there is no update manager, so I see:

Cc[aContract] is undefined XPCOMUtils.jsm:144
    XPCU_serviceLambda resource://gre/modules/XPCOMUtils.jsm:144
    get resource://gre/modules/XPCOMUtils.jsm:58
    lastBrowserUpdateDate resource:///modules/UrlbarProviderSearchTips.jsm:496
    _maybeShowTipForUrl resource:///modules/UrlbarProviderSearchTips.jsm:361
    InterpretGeneratorResume self-hosted:1468
    AsyncFunctionNext self-hosted:674

on release. AFAICT this code is all still there on nightly.

It should probably check AppConstants.MOZ_UPDATER or something.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1672146 - Make UrlbarProviderSearchTips deal with the update manager not existing.

In the bug, Gijs suggests checking AppConstants.MOZ_UPDATER, but the stack
shows that Cc[aContract] isn't defined, so it seems better to check for that
instead.

I'm not sure how or whether it's even possible to write a test where there's no
updater, so I haven't added one, and in the case where there is an updater,
that's covered by our existing tests of course.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f03b9e19229e
Make UrlbarProviderSearchTips deal with the update manager not existing. r=harry

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f03b9e19229e