Closed Bug 1672171 Opened 4 years ago Closed 4 years ago

Perma toolkit/components/printing/tests/browser_modal_print.js | Uncaught exception - Wait for dialog - timed out after 50 tries when Gecko 84 switches to Late Beta on 2020-11-28

Categories

(Core :: Printing: Output, defect)

defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 + fixed
firefox84 + verified

People

(Reporter: aryx, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f6fb704e304ae68ccfefa5046a98a34e91262495&selectedTaskRun=VkD2kuxPQcuGduF_aJdJMg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319126319&repo=try&lineNumber=18087

[task 2020-10-20T12:36:01.805Z] 12:36:01 INFO - Entering test bound testPrintOnNewWindowDoesntClose
[task 2020-10-20T12:36:01.809Z] 12:36:01 INFO - Test that printing doesn't close a window with a single tab
[task 2020-10-20T12:36:01.810Z] 12:36:01 INFO - Buffered messages logged at 12:35:55
[task 2020-10-20T12:36:01.810Z] 12:36:01 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/toolkit/components/printing/tests/simplifyArticleSample.html" line: 0}]
[task 2020-10-20T12:36:01.811Z] 12:36:01 INFO - Buffered messages finished
[task 2020-10-20T12:36:01.812Z] 12:36:01 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/printing/tests/browser_modal_print.js | Uncaught exception - Wait for dialog - timed out after 50 tries.
[task 2020-10-20T12:36:01.812Z] 12:36:01 INFO - Leaving test bound testPrintOnNewWindowDoesntClose
[task 2020-10-20T12:36:01.813Z] 12:36:01 INFO - GECKO(6944) | MEMORY STAT | vsize 3176MB | residentFast 394MB | heapAllocated 124MB
[task 2020-10-20T12:36:01.813Z] 12:36:01 INFO - TEST-OK | toolkit/components/printing/tests/browser_modal_print.js | took 16466ms

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30390dc34813
Set the modal dialog pref in a subtest that relies on it.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

This error has occurred on today's Beta as Release simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=retry%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=90c6b1f36ac3e9d8ff68b6aaa591c6611d9ac011&selectedTaskRun=X-u__SWFQGSRGRDiedEXpQ.0

I think this patch should be uplifted on beta.

Emilio, could you take a look?

Flags: needinfo?(emilio)

Comment on attachment 9182616 [details]
Bug 1672171 - Set the modal dialog pref in a subtest that relies on it.

Beta/Release Uplift Approval Request

  • User impact if declined: None, test-only change.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Set a pref on a test.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9182616 - Flags: approval-mozilla-beta?

Comment on attachment 9182616 [details]
Bug 1672171 - Set the modal dialog pref in a subtest that relies on it.

Approved for beta

Attachment #9182616 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: