Closed Bug 1672198 Opened 5 years ago Closed 4 years ago

Events need a "raw" RLB API for records coming over FOG IPC

Categories

(Data Platform and Tools :: Glean: SDK, task, P1)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Dexter, Assigned: janerik)

References

(Blocks 1 open bug)

Details

(Whiteboard: [telemetry:fog:m6])

Attachments

(1 file, 1 obsolete file)

Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1549
42 bytes, text/x-github-pull-request
Details | Review

See https://github.com/mozilla/glean/pull/1264#discussion_r508548964.

re timestamp: we kinda do need that API.
For FOG's IPC we need to get the timestamp immediately, pass that through the IPC layer and then later record the full event.
What we could do though is having a special* record_with_timestamp API on the RLB only, not on the trait

  • I already dislike the "special" API, but I don't see a way around it
See Also: → 1671628
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:fog:m6]
See Also: → 1680739
Blocks: 1692318
Summary: Do we need to expose 'timestamp' from rust traits? → Events need a "raw" RLB API for records coming over FOG IPC

This API should:

  • Accept a complete event record
  • Not be included in the glean-core trait
Depends on: 1672179, 1693486
Assignee: nobody → jrediger
Priority: P3 → P1
Blocks: 1698518

badboy merged PR #1549: "Bug 1672198 - RLB: Allow to record an event with the provided timestamp" in 70529f0.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9209134 [details]
Bug 1672198 - Upgrade Glean to get new time API. r?chutten!

Revision D108448 was moved to bug 1698518. Setting attachment 9209134 [details] to obsolete.

Attachment #9209134 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: