1672346 - PurgeTrackerService malformed URI exception when attempting to purge cookies

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Kestrel]

Nightly 84 with first party isolation enabled (privacy.firstparty.isolate = true) and tab containers in use.

The following exception happens when the PurgeTrackerService encounters the first tracker without interaction, at which point it stops without purging any cookies.

*** PurgeTrackerService:: Maybe purging http://youtube.com^firstPartyDomain=youtube.com.
Uncaught (in promise) 
Exception { name: "NS_ERROR_MALFORMED_URI", message: "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI]", result: 2152398858, filename: "resource://gre/modules/PurgeTrackerService.jsm", lineNumber: 114, columnNumber: 0, data: null, stack: "isAllowedThirdParty@resource://gre/modules/PurgeTrackerService.jsm:114:27\nmaybePurgePrincipal@resource://gre/modules/PurgeTrackerService.jsm:183:22\nasync*purgeTrackingCookieJars@resource://gre/modules/PurgeTrackerService.jsm:383:18\nasync*@debugger eval code:2:132\n@debugger eval code:3:3\ngetEvalResult@resource://devtools/server/actors/webconsole/eval-with-debugger.js:243:24\nexports.evalWithDebugger@resource://devtools/server/actors/webconsole/eval-with-debugger.js:167:14\nevaluateJS@resource://devtools/server/actors/webconsole.js:1118:38\nevaluateJSAsync/<@resource://devtools/server/actors/webconsole.js:1012:29\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22\n", location: XPCWrappedNative_NoHelper }
PurgeTrackerService.jsm:114

firstPartyOrigin: "https://mozilla.invisionapp.com^firstPartyDomain=invisionapp.com"
thirdPartyHost: "youtube.com"

Comment 1

[Johann Hofmann [:johannh]]

Ah, whoops, thanks for filing that :)

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1672346 - Use originNoSuffix for building uris for entity list lookup in PurgeTrackerService. r=timhuang

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f49a6ca40e
Use originNoSuffix for building uris for entity list lookup in PurgeTrackerService. r=timhuang

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c9f49a6ca40e

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:johannh, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9183858 [details]
Bug 1672346 - Use originNoSuffix for building uris for entity list lookup in PurgeTrackerService. r=timhuang

Beta/Release Uplift Approval Request

• User impact if declined: Redirect tracker protection isn't fully running for some users with containers or FPI enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A simple patch that switches to accessing a different member variable. The functionality is well covered with tests. The worst that could come out of this change is that purging is broken, which it is for these users anyway. Note that I wouldn't consider this patch urgent as we're dealing with some other issues around purging anyway.
• String changes made/needed: None

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9183858 [details]
Bug 1672346 - Use originNoSuffix for building uris for entity list lookup in PurgeTrackerService. r=timhuang

Given that this is a S3 and that we are building our RC build today, I am going to let it ride the 84 train, it will be in 84 beta net week, thanks.