Closed Bug 1672428 Opened 4 years ago Closed 4 years ago

Merge the paths for running hazard analysis locally and in automation

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(11 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

I implemented mach commands for running the hazard analysis, but the actual analysis is still controlled through separate shell scripts. That has resulted in them diverging, and creates duplicate code. I would like to switch all but a basic wrapper to mach.

Assignee: nobody → sphink
Status: NEW → ASSIGNED
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Depends on: 1672400
Severity: -- → N/A
Priority: -- → P3

I wanted this because I was running out of memory during a compile, and I wanted to pass -j4 to limit the number of parallel jobs.

Attachment #9184983 - Attachment description: Bug 1672428 - Add `mach build` command-line arguments to `mach hazards build-shell` → Bug 1672428 - Add `mach build` command-line arguments to `mach hazards gather`
Attachment #9184984 - Attachment description: Bug 1672428 - Bug hg next - Remove a layer of mapping from "project" to "application" → Bug 1672428 - Remove a layer of mapping from "project" to "application"
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4bfb3b97dd2 Use `mach hazards build-shell` for actual hazard job JS shell r=jonco https://hg.mozilla.org/integration/autoland/rev/e2a7870358ac Allow simultaneous browser and shell instances of the hazard analysis r=jonco https://hg.mozilla.org/integration/autoland/rev/fa2d59a19bcf Add `mach build` command-line arguments to `mach hazards gather` r=jonco https://hg.mozilla.org/integration/autoland/rev/0c5af7decad2 Remove a layer of mapping from "project" to "application" r=jonco https://hg.mozilla.org/integration/autoland/rev/b0132ea16a42 Add in partial support for finding tools in automation paths in addition to `mach hazard bootstrap` paths for developer builds r=jonco https://hg.mozilla.org/integration/autoland/rev/036d1664eb62 Reformatted some code with black r=jonco https://hg.mozilla.org/integration/autoland/rev/e41138cdc5ac Switch the actual analysis to mach r=jonco https://hg.mozilla.org/integration/autoland/rev/38cf4fe6e57d Run a self-test before doing the actual analysis. r=jonco https://hg.mozilla.org/integration/autoland/rev/5cb551f8bb22 Dodge -Wtype-limits warning r=jonco https://hg.mozilla.org/integration/autoland/rev/f9332f40f355 Remove hazard-analysis.sh r=jonco
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: