1672533 - Dedupe SERPs in history whose query parameters are a subset of a generated search URL

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Harry Twyford]

One of the biggest issues with the restyleSearches pref is that it does not restyle this URL:

https://google.com/search?q=test

Restyling happens by extracting the search term from the SERP in history (in this case, test) then generating a search URL with that search term. We restyle the SERP in history if it has nearly identical query parameters to the generated SERP. The problem is that the generated URL contains our attribution parameter(s) for that engine:

https://google.com/search?client=firefox-b-d&q=test

This fails to restyle organic searches, which is most of the point of the feature. Rather than checking for exact equivalence between the two sets of query parameters, we should check that the history parameters are a subset of the generated query parameters. That way we restyle the first URL above, which is a common case, but still don't restyle history SERPs with parameters that indicate that they are something other than a first-page web SERP. That is, we still won't restyle a URL like

https://google.com/search?q=test&page=2&type=img

Comment 1

[Harry Twyford]

Attachment: Bug 1672533 - Dedupe SERPs in history whose query parameters are a subset of a generated search URL.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05efb40a709a
Dedupe SERPs in history whose query parameters are a subset of a generated search URL. r=adw

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/05efb40a709a