1672593 - Paragraph offsets wrong when starting from inline content and there is a block element afterwards

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Discovered in https://phabricator.services.mozilla.com/D94024?id=355290#inline-533431.

STR (with the NVDA screen reader):

1. Open this test case:
   data:text/html,<a href="https://mozilla.org/">a</a><p>b</p>
2. Focus the document.
3. Press NVDA+control+z to open the NVDA python Console.
4. Enter the following command and press enter:
   focus.IAccessibleTextObject.textAtOffset(0, 3)
   • Expected: (0, 1, ' ')
   • Actual: (0, 2, ' ')

Comment 1

[James Teh [:Jamie]]

(Removed unintentional comment.)

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1672593: When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95f37d6e239c
When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it. r=MarcoZ

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/95f37d6e239c

Comment 5

[Marco Zehe (:MarcoZ)]

Verified fixed in Firefox 84.0a1 (20201022215159).

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 9183090 [details]
Bug 1672593: When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it.

Beta/Release Uplift Approval Request

• User impact if declined: Users of assistive technologies could get wrong information which text is contained within a paragraph under some circumstances.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None.
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds one more condition for a paragraph's end offset, has test coverage.
• String changes made/needed: None.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9183090 [details]
Bug 1672593: When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it.

Verified on Nightly and we are early in beta, uplift approved for 83 beta 4, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7bb5d04a685