1672621 - Crash in [@ mozilla::layers::TextureClientRecycleAllocator::CreateOrRecycle]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/05f27106-e515-4fed-8203-260e50201022

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::layers::TextureClientRecycleAllocator::CreateOrRecycle gfx/layers/client/TextureClientRecycleAllocator.cpp:153
1 xul.dll mozilla::layers::D3D11RecycleAllocator::CreateOrRecycleClient gfx/layers/D3D11ShareHandleImage.cpp:183
2 xul.dll mozilla::layers::D3D11ShareHandleImage::AllocateTexture gfx/layers/D3D11ShareHandleImage.cpp:39
3 xul.dll mozilla::D3D11DXVA2Manager::CopyToImage dom/media/platforms/wmf/DXVA2Manager.cpp:912
4 xul.dll mozilla::WMFVideoMFTManager::CreateD3DVideoFrame dom/media/platforms/wmf/WMFVideoMFTManager.cpp:966
5 xul.dll mozilla::WMFVideoMFTManager::Output dom/media/platforms/wmf/WMFVideoMFTManager.cpp:1098
6 xul.dll mozilla::WMFMediaDataDecoder::ProcessOutput dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:154
7 xul.dll mozilla::WMFMediaDataDecoder::ProcessDecode dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:143
8 xul.dll mozilla::detail::ProxyRunnable<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1>, RefPtr<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1> >  xpcom/threads/MozPromise.h:1457
9 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:158

Comment 1

[Matt Woodrow (:mattwoodrow)]

This is crashing because GetAllocator() returns nullptr.

Looks like that can only be null if the TextureClient was created without one, and given that this is D3D11ShareHandleImage, that must mean this code returned nullptr: https://searchfox.org/mozilla-central/rev/ff85081e3b05f89f9a5921b489b6e01ed4a88c25/gfx/layers/D3D11ShareHandleImage.cpp#124

Looks like that can happen in the RDD process, if the GPU process has crashed: https://searchfox.org/mozilla-central/rev/ff85081e3b05f89f9a5921b489b6e01ed4a88c25/dom/media/ipc/RemoteVideoDecoder.cpp#38

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1672621 - Don't create new texture clients if our forwarder has gone away. r?kamidphish

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4341527c628
Don't create new texture clients if our forwarder has gone away. r=jya

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a4341527c628