1672650 - Transpile TypeOf ICs

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

This is a measurable speedup on some tests like the hash-map test in JetStream2.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1672650 part 1 - Optimize MTypeOf with known-object input better. r?anba!

Instead of always boxing the input, we now allow unboxed objects and use
LTypeOfO instead of LTypeOfV in that case.

This will let us transpile LoadTypeOfObjectResult more efficiently.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1672650 part 2 - Support LoadConstantStringResult and LoadTypeOfObjectResult in the transpiler. r?anba!

Depends on D94427

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1672650 part 3 - Support transpiling TypeOf CacheIR. r?anba!

Depends on D94428

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1672650 part 4 - Don't use GuardIsNumber for typeof on int32 values. r?anba!

This is a small improvement on the hash-map test in JetStream 2 because we can
fold more MIR instructions and don't unbox to double.

Depends on D94429

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab695d09f52
part 1 - Optimize MTypeOf with known-object input better. r=anba
https://hg.mozilla.org/integration/autoland/rev/73b7bc28e9af
part 2 - Support LoadConstantStringResult and LoadTypeOfObjectResult in the transpiler. r=anba
https://hg.mozilla.org/integration/autoland/rev/e8571ec1606b
part 3 - Support transpiling TypeOf CacheIR. r=anba
https://hg.mozilla.org/integration/autoland/rev/0e882aaf85ab
part 4 - Don't use GuardIsNumber for typeof on int32 values. r=anba

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2ab695d09f52
https://hg.mozilla.org/mozilla-central/rev/73b7bc28e9af
https://hg.mozilla.org/mozilla-central/rev/e8571ec1606b
https://hg.mozilla.org/mozilla-central/rev/0e882aaf85ab