Closed Bug 1672751 Opened 4 years ago Closed 2 months ago

Collect HLS playback info on Android.

Categories

(Core :: Audio/Video: Playback, defect)

defect

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: bryce, Assigned: jhlin)

References

(Blocks 4 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

I don't think we're actually recording these probes as we expect. The histograms[0] don't have GV config as far as I can tell.

[0] https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/toolkit/components/telemetry/Histograms.json#9770,9779

Assignee: nobody → jolin

Modify the probes and change the bug title. We will record events when a HLS media is loaded. The collected info includes:

  • the hostnames in the master playlist and media file URLs, to identify the websites that serve HLS contents
  • the format of media files, to determine if MPEG-TS is still in use.
Summary: MEDIA_HLS_CANPLAY_REQUESTED + MEDIA_HLS_CANPLAY_SUPPORTED telemetry is not recorded on GeckoView → Collect HLS playback info on Android.
Attached file Data review request form (obsolete) —

Requesting Data Review.

Attachment #9391809 - Flags: data-review?(chutten)

Comment on attachment 9391809 [details]
Data review request form

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 132.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

The collection of URLs (including just the host name) is at least Category 3, Stored Content and Communications.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview-, for all-channel default-on collection of Category 3 data.

Attachment #9391809 - Flags: data-review?(chutten) → data-review-

From here there are two paths:

  1. Don't collect the host name. That'll render this collection as Category 1 and it'll be clear to be collected under normal parameters.
  2. Continue with Sensitive Data Collection Review to ascertain if this default-on collection of host names is permitted under these circumstances. It might be, but as a Data Steward I can't say. Just follow the process (( which is basically writing an email pointing at this data collection review )), and if the panel comes back that this is acceptable, we can flip that flag to data-review+ and carry on.
Blocks: 1887053
Attachment #9391793 - Attachment description: Bug 1672751 - record HLS host and format info on Android. r=azebrowski → Bug 1672751 - record HLS host and format info on Android.
Attachment #9391793 - Attachment description: Bug 1672751 - record HLS host and format info on Android. → WIP: Bug 1672751 - record HLS format info on Android.
Attachment #9391793 - Attachment description: WIP: Bug 1672751 - record HLS format info on Android. → WIP: Bug 1672751 - record HLS playback info on Android.

(In reply to Chris H-C :chutten from comment #5)

From here there are two paths:

  1. Don't collect the host name. That'll render this collection as Category 1 and it'll be clear to be collected under normal parameters.
  2. Continue with Sensitive Data Collection Review to ascertain if this default-on collection of host names is permitted under these circumstances. It might be, but as a Data Steward I can't say. Just follow the process (( which is basically writing an email pointing at this data collection review )), and if the panel comes back that this is acceptable, we can flip that flag to data-review+ and carry on.

Thanks a lot for the review! Looks like the hostname needs more time to process. I'll move that to bug 1887053 and continue with the proper review there so we can start collecting the data to decide whether the 3rd party ExoPlayer library is still needed sooner.

Also reviving the old probes to help answer whether there are still many HLS content support checks (on desktop and Android, respectively).

Attachment #9391809 - Attachment is obsolete: true
Attachment #9392815 - Flags: review?(chutten)
Attachment #9391793 - Attachment description: WIP: Bug 1672751 - record HLS playback info on Android. → Bug 1672751 - record HLS playback info on Android.

Comment on attachment 9392815 [details]
revised data review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 132.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9392815 - Flags: review?(chutten) → data-review+
Attachment #9391793 - Attachment description: Bug 1672751 - record HLS playback info on Android. → WIP: Bug 1672751 - record HLS playback info on Android.
Attachment #9391793 - Attachment description: WIP: Bug 1672751 - record HLS playback info on Android. → Bug 1672751 - record HLS playback info on Android.
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d716edeb28d
record HLS playback info on Android. r=alwu
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Blocks: 1896931
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: