1672778 - ThreadActor is not destroyed when content process target is destroyed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandre Poirot [:ochameau]]

ContentProcessTargetActor isn't calling ThreadActor.exit, whereas this is the only way to fully destroy this special actor. That's because ThreadActor.destroy isn't calling Actor.destroy. Instead ThreadActor.exit does it.
So that destroying the target actor, which manages the thread actor, will call all its children actor's destroy method. But we expect to call exit.

BrowsingContext target actor has a special code to do that right:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1011
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1046
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#641
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#620

We could probably benefit from cleaning up/removing this "exit" logic in favor of a unique destroy codepath.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1672778 - [devtools] Destroy the thread actor when the content process actor is destroyed.

We have to manually call exit as calling destroy won't completely destroy it.
ThreadActor.destroy do not call protocoljs.Actor.destroy, ThreadActor.exit does it.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1672778 - [devtools] Avoid trying to send new-source event if the thread actor has been destroyed.

This may prevent logging a few exception or error messages.
But thanks to the other patch of this bug, we should try to stop listening
for sources as soon as the thread actor is destroyed.

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf75c28e5824cfb8f00acdacd001e121086a6540

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b2bfa482a553968e0c61b724278332abd5f1088

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9620179e672b
[devtools] Destroy the thread actor when the content process actor is destroyed. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/43b98bc28bdc
[devtools] Avoid trying to send new-source event if the thread actor has been destroyed. r=nchevobbe

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9620179e672b
https://hg.mozilla.org/mozilla-central/rev/43b98bc28bdc