1672787 - Filter down CacheIR Health Report JSON output

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Caroline Cullen [:caroline]]

The JSON output, even for small scripts, is very large. For something like GDocs the output of the report is not a reasonable size. In order to generate smaller reports for websites it is important to filter for the interesting cases in C++. These cases include when ICs transition into polymorphic, megamorphic, or generic mode.

This will require adding a bit on scripts saying "hey we care about this script and its final warmup count" and adding back in the warmup counter to continue counting in Warp for the scripts that we are interested in.

Comment 1

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 1: Pull maybeTransition and its conditional function calls into a MaybeTransition function. r?iain

Comment 2

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 2: Add definition for JS_CACHEIR_SPEW to jsapi-tests build file. r?iain

Depends on D98660

Comment 3

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 3: Spew CacheIR health report when we are non-monomorphic. r?iain

Depends on D98661

Comment 4

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 4: Mark scripts when we are interested in their final warmup count. r?iain

Depends on D98662

Comment 5

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 5: Add mir node for incrementing the warmup counter. r?iain

Depends on D98663

Comment 6

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 6: Record final script warm up counts for the scripts we care about. r?iain

Depends on D98664

Comment 7

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 7: Allow temporary disabling of structured spewing. r?mgaudet

Depends on D98665

Comment 8

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 8: Add spew function for final warm up count. r?iain

Depends on D98666

Comment 9

[Caroline Cullen [:caroline]]

Attachment: Bug 1672787 - Part 9: Spew final warm up count during finalization. r?iain

Depends on D98667

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d74a988072
Part 1: Pull maybeTransition and its conditional function calls into a MaybeTransition function. r=iain
https://hg.mozilla.org/integration/autoland/rev/2c61c748777d
Part 2: Add definition for JS_CACHEIR_SPEW to jsapi-tests build file. r=iain
https://hg.mozilla.org/integration/autoland/rev/11b3eb7086d9
Part 3: Spew CacheIR health report when we are non-monomorphic. r=iain
https://hg.mozilla.org/integration/autoland/rev/b5760db8691e
Part 4: Mark scripts when we are interested in their final warmup count. r=iain
https://hg.mozilla.org/integration/autoland/rev/dd8c2e864b7c
Part 5: Add mir node for incrementing the warmup counter. r=iain
https://hg.mozilla.org/integration/autoland/rev/83c28f165cf2
Part 6: Record final script warm up counts for the scripts we care about. r=iain
https://hg.mozilla.org/integration/autoland/rev/1399535c5b85
Part 7: Allow temporary disabling of structured spewing. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a1dfe929b67c
Part 8: Add spew function for final warm up count. r=iain
https://hg.mozilla.org/integration/autoland/rev/1387fe7fd09d
Part 9: Spew final warm up count during finalization. r=iain

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/89d74a988072
https://hg.mozilla.org/mozilla-central/rev/2c61c748777d
https://hg.mozilla.org/mozilla-central/rev/11b3eb7086d9
https://hg.mozilla.org/mozilla-central/rev/b5760db8691e
https://hg.mozilla.org/mozilla-central/rev/dd8c2e864b7c
https://hg.mozilla.org/mozilla-central/rev/83c28f165cf2
https://hg.mozilla.org/mozilla-central/rev/1399535c5b85
https://hg.mozilla.org/mozilla-central/rev/a1dfe929b67c
https://hg.mozilla.org/mozilla-central/rev/1387fe7fd09d