1672837 - repack_rust: ValueError: not enough values to unpack (expected 2, got 1)

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Mike Hommey [:glandium]]

[task 2020-10-22T20:05:18.531Z] Traceback (most recent call last):
[task 2020-10-22T20:05:18.531Z]   File "workspace/build/src/taskcluster/scripts/misc/repack_rust.py", line 550, in <module>
[task 2020-10-22T20:05:18.531Z]     repack(**args)
[task 2020-10-22T20:05:18.531Z]   File "workspace/build/src/taskcluster/scripts/misc/repack_rust.py", line 357, in repack
[task 2020-10-22T20:05:18.531Z]     rustc = fetch_package(manifest, 'rustc', host)
[task 2020-10-22T20:05:18.531Z]   File "workspace/build/src/taskcluster/scripts/misc/repack_rust.py", line 239, in fetch_package
[task 2020-10-22T20:05:18.531Z]     sha = fetch(info['url'], info['hash'] is not None)
[task 2020-10-22T20:05:18.531Z]   File "workspace/build/src/taskcluster/scripts/misc/repack_rust.py", line 196, in fetch
[task 2020-10-22T20:05:18.531Z]     verify_sha(base, sha)
[task 2020-10-22T20:05:18.531Z]   File "workspace/build/src/taskcluster/scripts/misc/repack_rust.py", line 175, in verify_sha
[task 2020-10-22T20:05:18.531Z]     checksum, name = f.readline().split()
[task 2020-10-22T20:05:18.531Z] ValueError: not enough values to unpack (expected 2, got 1)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1672837 - Don't fail to repack recent rust nightlies.

The contents of the .sha256 files have changed two days ago and don't
contain the file name anymore. Considering the file name is already in
the sha256 file name, we can assume it matches. The file name check was
only an additional assurance. We could keep it conditionally, but
in only a few months, all the ones we care about will have switched to
the new format.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd9f73712f1f
Don't fail to repack recent rust nightlies. r=firefox-build-system-reviewers,rstewart

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bd9f73712f1f