1672918 - Add words to en-US dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, task)

Comment 1

[Ekanan Ketunuti]

Attachment: 00001-wip-bug-1672918.patch

Comment 2

[Ekanan Ketunuti]

^
^
from bug 499593 comment 352 - 408.

I'll do the rest of it later.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1672918 - Add words to en-US dictionary r=sylvestre

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Excellent, thanks.
I pushed it to phabricator on your behalf.

I think we could land this one now, don't you think?

Comment 5

[Ekanan Ketunuti]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Excellent, thanks.
I pushed it to phabricator on your behalf.

I think we could land this one now, don't you think?

Testing failed with the word "subpoenable". I'll fix that in full patch, tomorrow maybe. :)

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Sounds good! I really don't mind uploading/reviewing the patches for you!

Btw, how do you run tests for this? (I don't know :)

Comment 7

[Ekanan Ketunuti]

Just mv en-US.dic en-US.aff (optional) into firefox dictionaries folder (I do this with Firefox 62 because not yet bundled to om.ja (bug 1457321). easier for me to hack) and test it by hand.

Pasting all words into textarea. ^ ^

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Oh ok, thanks :)
I thought we had automatic tests for this!

Comment 9

[Ekanan Ketunuti]

Attachment: added-words.txt

Comment 10

[Ekanan Ketunuti]

Attachment: bug1672918.patch

patch for review

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Ekanan, is it good to go ? :)

Comment 12

[Ekanan Ketunuti]

Yeah, it is, good to go. :)

Comment 13

[mlissner]

I'm thrilled to see these words finally getting merged in! Thank you both so much!

Comment 14

[mlissner]

Is there any energy to try to merge the 6k words from Merriam Webster's dictionary that are in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=499593#c407. The list includes every word added to their dictionary between 1920 and 2020 that isn't in Firefox (I checked manually, ugh).

I think adding all of these would go a LONG way towards fixing this issue once and for all so we don't have to rely on onesie-twosie patches like this one.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

The main issue with the 6k words is that it doesn't have the /XXX annotations (ending with ed, ing, etc).

Maybe we could merge as it but I am not sure what we expect in term of quality

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d56405b0d96e
Add words to en-US dictionary

Comment 17

[mlissner]

Yes, dealing with that would be a huge undertaking. If there's a way to automate that, I could take a stab. I wouldn't want to do a perfect job, probably, but just a good enough job that we can land it without people being annoyed/confused/etc.

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d56405b0d96e