1672965 - The cursor doesn't change anymore when hovering a link or button on a website while uBlock Origin is opened

Status: NEW

(Core :: Graphics, defect)

Description

[Francois Guerraz]

D94552 fixes Bug 1672139 for me, but then hovering on links doesn't trigger events any more (no change of mouse pointer, etc.)

Comment 1

[Darkspirit]

Gnome Wayland, Debian Testing, Intel/Mesa
The described problem occurs as long as uBlock Origin is opened. The regression range is correct. EGL and GLX on Xwayland are affected as well.
(As the change was made in CompositorBridgeParent.cpp I would assume this is a cross-platform bug.)

STR:
Install uBlock Origin and open its panel.
Hover the "Remove" button or the "Raymond Hill" link on addons.mozilla.org.
The cursor doesn't change. It should.

https://hg.mozilla.org/integration/autoland/shortlog/0cb613d53e83
last good:
mozregression --repo autoland --launch 3865219ee14c65f5f23207ca073d070e31120938 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

first bad:
mozregression --repo autoland --launch 0cb613d53e83 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

Comment 2

[Sotaro Ikeda [:sotaro]]

:kats, do you have any ideas why the problem happens?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Not off the top of my head. The patch you landed seems quite far away from the codepath for changing the mouse cursor. As far as I can recall, the uiController stuff should only be relevant on Android, and composition payload stuff is mostly for measuring latency. So it's probably the FlushTransactionIdsForEpoch call that's the problem. I don't know how though. I can look more on Monday if you don't figure it out by then.

Comment 4

[Darkspirit]

Today I get different results! (Yesterday I tested these seperately as well.)
It can also reproduced with opening the context menu. As long as the context menu is open, the cursor doesn't change when hovering links on a website.

On Wayland, "last good" is good.
MOZ_ENABLE_WAYLAND=1 mozregression --repo autoland --launch 3865219ee14c65f5f23207ca073d070e31120938 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin
On Wayland, "first bad" is also good.
MOZ_ENABLE_WAYLAND=1 mozregression --repo autoland --launch 0cb613d53e83 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

On Xwayland, "last good" is bad.
mozregression --repo autoland --launch 3865219ee14c65f5f23207ca073d070e31120938 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin
On Xwayland, "first bad" is bad.
mozregression --repo autoland --launch 0cb613d53e83 --pref gfx.webrender.all:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

Comment 5

[Darkspirit]

Another maybe related bug: If It hover a button in uBlock Origin, get the "cursor:pointer" state and move my mouse fast enough out of the uBlock Origin panel, the cursor remains a "cursor:pointer".

Comment 6

[Darkspirit]

Not a WebRender bug.
Both bugs (comment 0 + comment 5) can be reproduced with Basic and Nightly 2018-02-10 on Xwayland.
mozregression --launch 2018-02-10 --pref gfx.webrender.force-disabled:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

Even 2017-02-10 and 2015-02-10 are affected. I tested with opening the context menu.
mozregression --launch 2017-02-10 --pref gfx.webrender.force-disabled:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin
mozregression --launch 2015-02-10 --pref gfx.webrender.force-disabled:true -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin

Comment 7

[Francois Guerraz]

I think this bug, the way it's been modified, is now a duplicate Bug 1615098.
When I submitted it it was a regression from Bug 1672139. But as of this morning in autoland it works for me.

Darkspirit, should we close it?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Echoing what Darkspirit said in comment 6, I can repro this on pretty old builds. So I'm not sure this is a bug at all. Certainly it doesn't seem to be a regression from bug 1672139.

Comment 9

[Darkspirit]

STR comment 1, comment 4 and comment 5 are still reproducible.
mozregression --launch 2021-09-16 --pref -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin