1672997 - Sponsored Label is not delimited from TopSite title on narrowed windows

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Attachment: Sponsored Label is not delimited from TopSite title

[Affected versions]:

• Firefox 83.0b1
• Nightly 84.0a1 2020-10-23

[Affected platforms]:

• Win 10 x64

[Steps to reproduce]:

1. Make sure that at least one topsite from Remote Settings configuration has the "Sponsored" label.
2. Set a Firefox profile to connect to the Kinto Staging configuration while switching the browser.topsites.useRemoteSetting preference to true.
3. Click inside the address bar and check the listed topsites - "Sponsored" label is shown instead of the URL for sponsored topsites
4. Narrow the browser width so that the address bar topsites URLs are shown on the second line

[Expected result]:

• Either "Sponsored" label is shown on the second line or there is another delimitation in place between title and label

[Actual result]:

• There is no delimitation between title and "Sponsored" label

[Regression range]:

• This issue is not a regression

[Suggested severity]:

• S4

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88621bb93444
Display separator before "Sponsored" top site label in narrow window. r=mak

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/88621bb93444

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9184735 [details]
Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: This will be verified as part of bug 1653929.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment 5

[Petruta Horea [:phorea]]

Verified as fixed using latest Nightly 84.0a1 2020-11-01 under Win 10 64-bit and Ubuntu 18.04 64-bit.
Leaving the flags for beta verification.

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9184735 [details]
Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak

Regression on a 83 feature in development, trivial fix, verified on nightly by QA, uplift approved for 83 beta 8, thanks.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d56a5f8353e8

Comment 8

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 83 beta 8 under Win 10 64-bit, Ubuntu 18.04 64-bit and Mac OSX 10.15.