1673036 - When a focused accessible is styled away a focus event is fired on its nearest ancestor

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Load data:text/html,<div role="grouping" aria-label="Group" id="grouping"><button onclick="this.style.visibility = 'hidden'; setTimeout(() => console.log(document.activeElement), 10)">kill me</button></div>
2. Tab to "kill me" button and activate it.

Result:
A focus accessibility even will be fired on the grouping, and the js console will print the button

Expected:
A focus accessibility event should be fired on the doc, and the js console should pring the body element.

While this is obviously a DOM bug (bug 1673035), the fix in a11y should be pretty simple.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

:eeejay: what are the priority and severity of this bug? It helps us to determine the one of bug 1673035.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1673036 - If focused accessible is styled away, emit focus event on document. r?Jamie!

Currently, the focus will be emitted on the accessible's visible
container, even if it is not focusable.

Comment 3

[Eitan Isaacson [:eeejay]]

Mirko,

I set a priority and severity. I managed to code around the DOM bug, so maybe it should be removed as a blocker?

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Eitan: yes, if it doesn't block this bug, please remove it as a blocker.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553a58ca7c5b
If focused accessible is styled away, emit focus event on document. r=Jamie

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/553a58ca7c5b

Comment 7

[Cristian Fogel [:cfogel]]

Patch verified with 84.0b2, 85.0a1 (2020-11-19) on macOS 10.15.