1673051 - Remove OnYosemiteOrLater(), OnElCapitanOrLater(), and OnSierraOrLater()

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

After bug 1634765, we know that we always run on 10.12 (Sierra) or later. We should remove the nsCocoaFeatures methods that now always return true, and simplify the code that calls these methods.

Comment 1

[Stephen A Pohl [:spohl]]

Possible good-first-bug?

Comment 2

[Markus Stange [:mstange]]

Definitely.

Comment 3

[h20190017]

Hi, I would like to work on this bug. Can someone please guide me on how to start and further continue as this is my first bug fix and I have almost no idea. Thank you.

Comment 4

[lolrepeatlol]

(In reply to h20190017 from comment #3)

Hi, I would like to work on this bug. Can someone please guide me on how to start and further continue as this is my first bug fix and I have almost no idea. Thank you.

Hi there, new contributors would be great! A good place to ask questions like this is the #introduction channel on Matrix. Here's a link to that: https://chat.mozilla.org/#/room/#introduction:mozilla.org

You can read more about it here.

Comment 5

[Stephen A Pohl [:spohl]]

(In reply to h20190017 from comment #3)

Hi, I would like to work on this bug. Can someone please guide me on how to start and further continue as this is my first bug fix and I have almost no idea. Thank you.

First, you will want to have your build system set up: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Then, you will want to use https://searchfox.org/ to search for the three nsCocoaFeatures methods that were mentioned in comment 0. You will then need to open each of the files that reference any of these methods and remove them.

Once complete, you can read up on how to submit your patch here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Comment 6

[u672741]

Hi,
Is this bug still open for contribution?
If yes, then I would like to contribute.

Comment 7

[h20190017]

(In reply to Stephen A Pohl [:spohl] from comment #5)

(In reply to h20190017 from comment #3)

Hi, I would like to work on this bug. Can someone please guide me on how to start and further continue as this is my first bug fix and I have almost no idea. Thank you.

First, you will want to have your build system set up: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Then, you will want to use https://searchfox.org/ to search for the three nsCocoaFeatures methods that were mentioned in comment 0. You will then need to open each of the files that reference any of these methods and remove them.

Once complete, you can read up on how to submit your patch here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Thanks. I will give it a try.

Comment 8

[h20190017]

(In reply to Alexei Solonari from comment #4)

(In reply to h20190017 from comment #3)

Hi, I would like to work on this bug. Can someone please guide me on how to start and further continue as this is my first bug fix and I have almost no idea. Thank you.

Hi there, new contributors would be great! A good place to ask questions like this is the #introduction channel on Matrix. Here's a link to that: https://chat.mozilla.org/#/room/#introduction:mozilla.org

You can read more about it here.

Thanks a lot! I will look into it.

Comment 9

[NAMAN JAIN]

Attachment: Bug 1673051 - [core] Remove OnYosemiteOrLater(), OnElCapitanOrLater(), and OnSierraOrLater() widget/cocoa/nsCocoaFeatures.h. r=mccr8

Depends on D95117

Comment 10

[NAMAN JAIN]

Submitted the patch, Please review .

Comment 11

[akshay1992kalbhor]

Attachment: Bug 1673051 - Remove OnYosemiteOrLater(), OnElCapitanOrLater(), and OnSierraOrLater(). r=spohl

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c7dab13c9d0
Remove OnYosemiteOrLater(), OnElCapitanOrLater(), and OnSierraOrLater(). r=mstange

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3c7dab13c9d0