1673055 - Simplify VibrancyManager after dropping 10.9

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

VibrancyManager.mm has some workarounds for the fact that NSVisualEffectView wasn't available on 10.9. We no longer support 10.9, so this code can be simplified.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Simplify VibrancyManager.mm. r=haik

This removes some code which was creating new Objective C classes at runtime.
I originally wrote this code because NSVisualEffectView was a new class that
was added in 10.10, and we were building with a pre-10.10 SDK.

These days we build with the 10.11 SDK, which has NSVisualEffectView, and we
only run on 10.12+.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Simplify other code now that SystemSupportsVibrancy() always returns true. r=haik

Depends on D94622

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Remove always-true backgroundIsVibrant field. r=haik

Depends on D94629

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Remove now-unused MenuBackground widget drawing. r=haik

Depends on D94631

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Remove now-unused Tooltip widget drawing. r=haik

Depends on D94633

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1673055 - Remove now-unused SourceList widget drawing. r=haik

Depends on D94634

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/319226c99917
Simplify VibrancyManager.mm. r=haik
https://hg.mozilla.org/integration/autoland/rev/16f701601135
Simplify other code now that SystemSupportsVibrancy() always returns true. r=haik
https://hg.mozilla.org/integration/autoland/rev/8d7ff75d700a
Remove always-true backgroundIsVibrant field. r=haik
https://hg.mozilla.org/integration/autoland/rev/fc9d24f6ffbd
Remove now-unused MenuBackground widget drawing. r=haik,spohl
https://hg.mozilla.org/integration/autoland/rev/673508a5981e
Remove now-unused Tooltip widget drawing. r=haik
https://hg.mozilla.org/integration/autoland/rev/53a3638bf4ef
Remove now-unused SourceList widget drawing. r=haik

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/319226c99917
https://hg.mozilla.org/mozilla-central/rev/16f701601135
https://hg.mozilla.org/mozilla-central/rev/8d7ff75d700a
https://hg.mozilla.org/mozilla-central/rev/fc9d24f6ffbd
https://hg.mozilla.org/mozilla-central/rev/673508a5981e
https://hg.mozilla.org/mozilla-central/rev/53a3638bf4ef