Closed Bug 1673055 Opened 11 months ago Closed 11 months ago

Simplify VibrancyManager after dropping 10.9

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(6 files)

VibrancyManager.mm has some workarounds for the fact that NSVisualEffectView wasn't available on 10.9. We no longer support 10.9, so this code can be simplified.

This removes some code which was creating new Objective C classes at runtime.
I originally wrote this code because NSVisualEffectView was a new class that
was added in 10.10, and we were building with a pre-10.10 SDK.

These days we build with the 10.11 SDK, which has NSVisualEffectView, and we
only run on 10.12+.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/319226c99917
Simplify VibrancyManager.mm. r=haik
https://hg.mozilla.org/integration/autoland/rev/16f701601135
Simplify other code now that SystemSupportsVibrancy() always returns true. r=haik
https://hg.mozilla.org/integration/autoland/rev/8d7ff75d700a
Remove always-true backgroundIsVibrant field. r=haik
https://hg.mozilla.org/integration/autoland/rev/fc9d24f6ffbd
Remove now-unused MenuBackground widget drawing. r=haik,spohl
https://hg.mozilla.org/integration/autoland/rev/673508a5981e
Remove now-unused Tooltip widget drawing. r=haik
https://hg.mozilla.org/integration/autoland/rev/53a3638bf4ef
Remove now-unused SourceList widget drawing. r=haik
You need to log in before you can comment on or make changes to this bug.