1673062 - Intermittent TV browser/components/urlbar/tests/browser/browser_tokenAlias.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=319570235&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bGNSan7_SleDOfRwVknsVQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bGNSan7_SleDOfRwVknsVQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

...
[task 2020-10-23T16:53:44.774Z] 16:53:44     INFO - Entering test bound nonPrefixedKeyword
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - Awaiting for the urlbar panel to open
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_tokenAlias.js | Custom engine appears in the popup. - true == true - 
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - Buffered messages logged at 16:53:44
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_tokenAlias.js | The first result should be a keyword search result with the correct engine. - "Custom" == "Custom" - 
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - Leaving test bound nonPrefixedKeyword
[task 2020-10-23T16:53:44.775Z] 16:53:44     INFO - Buffered messages finished
[task 2020-10-23T16:53:44.776Z] 16:53:44     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_tokenAlias.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2020-10-23T16:53:44.776Z] 16:53:44     INFO - GECKO(1441) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2020-10-23T16:53:44.776Z] 16:53:44     INFO - GECKO(1441) | MEMORY STAT | vsize 7535MB | residentFast 277MB | heapAllocated 115MB
[task 2020-10-23T16:53:44.776Z] 16:53:44     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_tokenAlias.js | took 47797ms
...```

Comment 1

[Drew Willcoxon :adw]

The log shows that the last test task finishes, so it looks like the test is now just taking too long on these Mac machines in verify mode. There was another similar Mac verify intermittent I fixed recently by increasing the timeout. It makes sense in this case because I added a bunch of new checks in bug 1672680.

I'll take a look at splitting the test up, but I think it's probably fine to just request a longer timeout.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a320a06d40ddacfc76abc6cf097b11a959228c61

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1673062 - Fix intermittent TV browser/components/urlbar/tests/browser/browser_tokenAlias.js by increasing the timeout.

The log shows that the last test task finishes, so it looks like the test is now
just taking too long on these Mac machines in verify mode. That's plausible
because I added a bunch of new checks in bug 1672680 (checking for different
types of space characters).

Green try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a320a06d40ddacfc76abc6cf097b11a959228c61&selectedTaskRun=Geg2Cpj5Q16A4-KuYuegyw.0

Comment 4

[Intermittent Failures Robot]

1 failures in 4230 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1673062&startday=2020-10-19&endday=2020-10-25&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f165b9c934f
Fix intermittent TV browser/components/urlbar/tests/browser/browser_tokenAlias.js by increasing the timeout. r=mak

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9f165b9c934f

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1672680