1673129 - pressing the spacebar on the Downloads panel is both page-down and toggle-pause

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[tomprogers]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36

Steps to reproduce:

1. have several completed downloads in the Downloads Panel
2. start a new long-running download (2-min or more)
3. use pointer to select the in-progress download in the the Downloads Panel
4. press keyboard spacebar

Actual results:

download pauses AND list of downloads scrolls down one viewport-length

Expected results:

either the download should be pause OR the list should scroll, but not both

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

These large test files can be used to attempt to reproduce the issue.

Couldn't reproduce it with Ubuntu 18.04 and current Nightly.

Comment 2

[Anne (:annevk)]

I can with 84.0a1 (2020-10-23) (64-bit) on macOS.

Comment 3

[Marco Bonardo [:mak]]

This is apparently handled here, we should probably preventDefault() or stopPropagation() on the event, or the richlistbox will also try to handle it
https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/browser/components/downloads/content/downloads.js#859-861
the most complex part of the fix may actually to write a test, there's not many downloads tests, but some can be found under https://searchfox.org/mozilla-central/source/browser/components/downloads/test/browser

Comment 4

[Tanner Drake]

I can work on this.

Comment 5

[Tanner Drake]

Attachment: Bug 1673129: Prevent all downloads view from scrolling when toggling download resume pause state. r=mak

Comment 6

[Tanner Drake]

Attachment: Bug 1673129: Prevent all downloads view from scrolling when toggling download resume pause state. r=mak

Comment 7

[Tanner Drake]

ah I didn't mean to create a new revision. Is it possible to delete the old one? or delete the new one and I can patch the old one?

Comment 8

[Marco Bonardo [:mak]]

yes, you can amend changes to a changeset (using hg amend, I suggest using the evolve hg extension), merge changesets using hg rebase --collapse.
You can also mark an attachment as obsolete in Bugzilla and abandon a revision in Phabricator.
If you ran mach bootstrap, it should have also created an "hg wip" command that helps you seeing your changesets dependencies easily,

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ddab48a0544
Prevent all downloads view from scrolling when toggling download resume pause state. r=mak

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6ddab48a0544

Comment 11

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an oldere version on Nightly (2020-10-23) on Windows 10 x64.
I retested everything using Nightly 87.0a1 and Firefox 86.0b5 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.