Closed Bug 1673408 Opened 4 years ago Closed 4 years ago

Simplify marking of slots value ranges

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Currently GCMarker stores value ranges on the mark stack as either slots or elements ranges, and then for a slots range we work out whether it refers to fixed or dynamic slots later. We could simplify this by storing which kind of slots range we're referring to on the mark stack.

This stores the slots or elements range kind in the same word as the start
index (annoyingly there weren't enough spare bits to encode this in
MarkStack::TaggedPtr kind). This removes the need to add/subtract the number of
fixed slots when pushing/popping ranges for dynamic slots.

Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f64dc7ecb6e9 Store slots range kind on the mark stack r=sfink
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: