1673434 - Speedometer shows virtual keyboard on Android

Status: RESOLVED FIXED

(GeckoView :: IME, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

This is a regression.. bisecting.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

10:01.32 INFO: Last good revision: ec225bf5041b71830fb5fdc025232b99f6cd9809
10:01.32 INFO: First bad revision: 7b96efde9ee17f2c79245b7a6047fd686d7f4621
10:01.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ec225bf5041b71830fb5fdc025232b99f6cd9809&tochange=7b96efde9ee17f2c79245b7a6047fd686d7f4621

m_kato: any idea of what's going wrong here?

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

To reproduce visit https://browserbench.org/Speedometer2.0/ and run the test, it shouldn't open the virtual keyboard but it does with the change in Comment 1.

Comment 3

[Makoto Kato [:m_kato]]

Hmm, jQuery-TodoMVC causes this issue.

Comment 4

[Makoto Kato [:m_kato]]

why is form change user input event? ... https://hg.mozilla.org/mozilla-central/rev/febbc0b025c5ab6d1d96516698fe4374e6d7f63e

Comment 5

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab6b988b7d1fb0d670b84930d6c3b372d50fd671

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1673434 - change event isn't always user interaction event. r=masayuki

Software keyboard is shown by user interaction. But change event by
element.click() becomes user interaction event by bug 1543439 even if
it is called by script.

Since change event can be fired by click() method, we shouldn't be
that it is always user interaction.

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1673434 - Add user interaction test for input date type;

The change event should be treated as user interaction event if it is triggered
by user clicks date picker.
This is a follow-up of bug 1543439.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cefc4d4481c5
Add user interaction test for input date type; r=mconley

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84780a4376d6
change event isn't always user interaction event. r=edgar,masayuki

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cefc4d4481c5
https://hg.mozilla.org/mozilla-central/rev/84780a4376d6

Comment 11

[Chris Peterson [:cpeterson]]

Moving some keyboard bugs to the new GeckoView::IME component.